This repository was archived by the owner on Feb 6, 2025. It is now read-only.
Open
Conversation
Owner
|
I like the feature, though it now occurs to me that it might be a nicer API if we had something like this: Instead of: What do you think? That might be more of a "1.0" version :) If you update docs, I am in support of this feature as a temporary fix, though. |
Author
|
@darknoon That would be quite nice! One way might be by requiring some sort of I've updated the readme with information on using this feature as well as on subclassing, which might be helpful as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@darknoon Working with class methods recently so thought it'd be helpful to suggest the changes upstream. This reserves 2 properties, principally
classMethods, accepting an object of methods to add as class methods similar to how instance methods are added at object root. Thoughts?