Skip to content

Fix retrieval spelling in messages #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
darh78 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix retrieval spelling in messages #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R/viz_bp.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ viz_bp <- function(startseason, endseason = NULL, lg = "all", bat_metric = "wOBA
highcharter::hc_subtitle(text = paste0(x, " Season")) |>
# # adding credits and date when the chart was build
highcharter::hc_credits(enabled = TRUE,
text = paste0("Source: Baseball Reference. Using 'baseballr' R package. Retreived on: ",
text = paste0("Source: Baseball Reference. Using 'baseballr' R package. Retrieved on: ",
lubridate::with_tz(Sys.time(), "US/Eastern") |>
format("%Y-%m-%d %H:%M %Z"))) |>
# enable exporting option
Expand Down Expand Up @@ -193,7 +193,7 @@ viz_bp <- function(startseason, endseason = NULL, lg = "all", bat_metric = "wOBA
# ggplot2::labs(
# title = "MLB Teams wRC+ vs. ERA-",
# subtitle = paste0(season_data$Season[1], " Season"),
# caption = paste0("Source: Baseball Reference. Using 'baseballr' R package. Retreived on: ",
# caption = paste0("Source: Baseball Reference. Using 'baseballr' R package. Retrieved on: ",
# lubridate::with_tz(Sys.time(), "US/Eastern")))
#
# } )
Expand Down
6 changes: 3 additions & 3 deletions R/viz_rd.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ viz_rd <- function(team, year) {
if (intersect(grepl("AL|NL", team),
grepl("East|Central|West|Overall", team))) {
# Division or leagues in that year
message(paste0("Retreiving teams that played in ", team, " in ", year, "..."))
message(paste0("Retrieving teams that played in ", team, " in ", year, "..."))
teams <- baseballr::bref_standings_on_date(paste0(year,"-04-30"), team) |>
as.data.frame() |>
select(1) |>
Expand All @@ -62,7 +62,7 @@ viz_rd <- function(team, year) {
# All MLB teams in year
mlb <- c("AL Overall", "NL Overall")

message(paste0("Retreiving teams that played in ", team, " in ", year, "..."))
message(paste0("Retrieving teams that played in ", team, " in ", year, "..."))
teams <- pbapply::pbsapply(mlb, baseballr::bref_standings_on_date, date = paste0(year,"-04-30"))
teams <- c(teams[[1,1]], teams[[1,2]])

Expand Down Expand Up @@ -251,7 +251,7 @@ viz_rd <- function(team, year) {
}) |>
# adding credits and date when the chart was build
highcharter::hc_credits(enabled = TRUE,
text = paste0("Source: Baseball Reference. Using 'baseballr' R package. Retreived on: ",
text = paste0("Source: Baseball Reference. Using 'baseballr' R package. Retrieved on: ",
with_tz(Sys.time(), "US/Eastern") |>
format("%Y-%m-%d %H:%M %Z"))) |>
# enable exporting option
Expand Down
2 changes: 1 addition & 1 deletion R/viz_rd_team.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ viz_rd_team <- function(team, start_year, end_year, highlight_year = NULL) {
highcharter::hc_subtitle(text = paste("Between ", start_year, " and", end_year, ", highlighting the ", highlight_year, "season.")) |>
## Adding notes in the bottom of the chart
highcharter::hc_credits(enabled = TRUE, # add credits
text = paste0("Source: Baseball Reference. Using 'baseballr' R package. Retreived on: ",
text = paste0("Source: Baseball Reference. Using 'baseballr' R package. Retrieved on: ",
with_tz(Sys.time(), "US/Eastern") |>
format("%Y-%m-%d %H:%M %Z"))) |>
## Enabling the menu to export the charts
Expand Down
6 changes: 3 additions & 3 deletions R/viz_rd_wpct.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ viz_rd_wpct <- function(team, year) {
if (intersect(grepl("AL|NL", team),
grepl("East|Central|West|Overall", team))) {
# Division or leagues in that year
message(paste0("Retreiving teams that played in ", team, " in ", year, "..."))
message(paste0("Retrieving teams that played in ", team, " in ", year, "..."))
teams <- baseballr::bref_standings_on_date(paste0(year,"-04-30"), team) |>
as.data.frame() |>
select(1) |>
Expand All @@ -62,7 +62,7 @@ viz_rd_wpct <- function(team, year) {
# All MLB teams in year
mlb <- c("AL Overall", "NL Overall")

message(paste0("Retreiving teams that played in ", team, " in ", year, "..."))
message(paste0("Retrieving teams that played in ", team, " in ", year, "..."))
teams <- pbapply::pbsapply(mlb, baseballr::bref_standings_on_date, date = paste0(year,"-04-30"))
teams <- c(teams[[1,1]], teams[[1,2]])

Expand Down Expand Up @@ -266,7 +266,7 @@ viz_rd_wpct <- function(team, year) {
}) |>
# adding credits and date when the chart was build
highcharter::hc_credits(enabled = TRUE,
text = paste0("Source: Baseball Reference. Using 'baseballr' R package. Retreived on: ",
text = paste0("Source: Baseball Reference. Using 'baseballr' R package. Retrieved on: ",
with_tz(Sys.time(), "US/Eastern") |>
format("%Y-%m-%d %H:%M %Z"))) |>
# enable exporting option
Expand Down
6 changes: 3 additions & 3 deletions R/viz_streak.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ viz_streak <- function(team, year) {
if (intersect(grepl("AL|NL", team),
grepl("East|Central|West|Overall", team))) {
# Division or leagues in that year
message(paste0("Retreiving teams that played in ", team, " in ", year, "..."))
message(paste0("Retrieving teams that played in ", team, " in ", year, "..."))
teams <- baseballr::bref_standings_on_date(paste0(year,"-04-30"), team) |>
as.data.frame() |>
select(1) |>
Expand All @@ -36,7 +36,7 @@ viz_streak <- function(team, year) {
# All MLB teams in year
mlb <- c("AL Overall", "NL Overall")

message(paste0("Retreiving teams that played in ", team, " in ", year, "..."))
message(paste0("Retrieving teams that played in ", team, " in ", year, "..."))
teams <- pbapply::pbsapply(mlb, baseballr::bref_standings_on_date, date = paste0(year,"-04-30"))
teams <- c(teams[[1,1]], teams[[1,2]])

Expand Down Expand Up @@ -220,7 +220,7 @@ viz_streak <- function(team, year) {
}) |>
# adding credits and date when the chart was build
highcharter::hc_credits(enabled = TRUE,
text = paste0("Source: Baseball Reference. Using 'bbgraphsR' R package. Retreived on: ",
text = paste0("Source: Baseball Reference. Using 'bbgraphsR' R package. Retrieved on: ",
lubridate::with_tz(Sys.time(), "US/Eastern") |>
format("%Y-%m-%d %H:%M %Z"))) |>
# enable exporting option
Expand Down
6 changes: 3 additions & 3 deletions R/viz_wlp_season.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ viz_wlp_season <- function(lg_div, year) {
if (intersect(grepl("AL|NL", lg_div),
grepl("East|Central|West|Overall", lg_div))) {
# Division or leagues in that year
message(paste0("Retreiving teams that played in ", lg_div, " in ", year, "..."))
message(paste0("Retrieving teams that played in ", lg_div, " in ", year, "..."))
teams <- baseballr::bref_standings_on_date(paste0(year,"-04-30"), lg_div) |>
as.data.frame() |>
dplyr::select(1) |>
unlist()

} else if (lg_div == "MLB") {
message(paste0("Retreiving teams that played in ", lg_div, " in ", year, "..."))
message(paste0("Retrieving teams that played in ", lg_div, " in ", year, "..."))
teams_al <- baseballr::bref_standings_on_date(paste0(year,"-04-30"), "AL Overall")
teams_nl <- baseballr::bref_standings_on_date(paste0(year,"-04-30"), "NL Overall")
teams <- rbind(teams_al, teams_nl) |>
Expand Down Expand Up @@ -236,7 +236,7 @@ viz_wlp_season <- function(lg_div, year) {
) |>
highcharter::hc_subtitle(text = "Solid line(s) represent the Division(s) leader(s)") |>
highcharter::hc_credits(enabled = TRUE,
text = paste0("Source: Baseball Reference. Using 'baseballr' R package. Retreived on: ",
text = paste0("Source: Baseball Reference. Using 'baseballr' R package. Retrieved on: ",
lubridate::with_tz(Sys.time(), "US/Eastern") |>
format("%Y-%m-%d %H:%M %Z"))) |>
highcharter::hc_add_theme(highcharter::hc_theme_smpl()) |>
Expand Down
2 changes: 1 addition & 1 deletion R/viz_wlp_years.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ viz_wlp_years <- function(from_season, until_season = from_season + 1, league =
paste("W% in Reg. season (" , min(wl$Season), "-", max(wl$Season), "): <strong><span style='color: ", font_color, ";'>", teams_data$Wp_global[1]), "</span></strong> (", wl_whole$W, "-", wl_whole$L, ")")) |>
# # adding credits and date when the chart was build
highcharter::hc_credits(enabled = TRUE,
text = paste0("Source: Fangraph. Using 'bbraphsR' package. Retreived on: ",
text = paste0("Source: Fangraph. Using 'bbraphsR' package. Retrieved on: ",
lubridate::with_tz(Sys.time(), "US/Eastern") |>
format("%Y-%m-%d %H:%M %Z"))) |>
# enable exporting option
Expand Down