Skip to content

Stylesheet improvements #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
macbookandrew wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Stylesheet improvements #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4f5ab2
register and enqueue style in one call
macbookandrew Jan 24, 2017
c64e6cb
use child theme’s bootstrap.css (if applicable)
macbookandrew Jan 24, 2017
63a955d
use plugin version for stylesheet version number
macbookandrew Jan 24, 2017
38a6af5
use WP stylesheet enqueing rather than CSS @imports for better perfor…
macbookandrew Jan 24, 2017
5823177
pass $verison to enqueue function
macbookandrew Jan 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devdmbootstrap3-child/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Text Domain: devdmbootstrap3
Template: devdmbootstrap3
*/

@import "css/bootstrap.css";
/* The bootstrap.css file is auto-enqueued in functions.php */

/* YOU SHOULD BE MAKING A CHILD THEME. Don't let me be a bad guy and erase all your hard work with a theme update. I just want to bring you new amazing features. I don't want to destroy your world. I've include a child theme to use. Need help? http://devdm.com/DevDmBootstrap3/child-themes/ */

Expand Down
11 changes: 0 additions & 11 deletions devdmbootstrap3-sasschild/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1 @@
<?php

/*
* wp_dequeue bootstrap.css of the parent DevDemBootStrap3 theme
*/

function dmbs_dequeue_enqueue_scripts() {

wp_dequeue_style( 'bootstrap.css' );

}
add_action( 'wp_enqueue_scripts', 'dmbs_dequeue_enqueue_scripts', 100 );
2 changes: 1 addition & 1 deletion devdmbootstrap3-sasschild/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Text Domain: devdmbootstrap3
Template: devdmbootstrap3
*/

@import "css/bootstrap.css";
/* The bootstrap.css file is auto-enqueued in functions.php */

/* YOU SHOULD BE MAKING A CHILD THEME. Don't let me be a bad guy and erase all your hard work with a theme update. I just want to bring you new amazing features. I don't want to destroy your world. I've include a child theme to use. Need help? http://devdm.com/DevDmBootstrap3/child-themes/ */

Expand Down
7 changes: 3 additions & 4 deletions devdmbootstrap3/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,10 @@
////////////////////////////////////////////////////////////////////
// Enqueue Styles (normal style.css and bootstrap.css)
////////////////////////////////////////////////////////////////////
function devdmbootstrap3_theme_stylesheets()
function devdmbootstrap3_theme_stylesheets($version)
{
wp_register_style('bootstrap.css', get_template_directory_uri() . '/css/bootstrap.css', array(), '1', 'all' );
wp_enqueue_style( 'bootstrap.css');
wp_enqueue_style( 'stylesheet', get_stylesheet_uri(), array(), '1', 'all' );
wp_enqueue_style('bootstrap.css', get_stylesheet_directory_uri() . '/css/bootstrap.css', array(), $version, 'all' );
wp_enqueue_style( 'stylesheet', get_stylesheet_uri(), array(), $version, 'all' );
}
add_action('wp_enqueue_scripts', 'devdmbootstrap3_theme_stylesheets');

Expand Down