Add support for verifying reply addresses#172
Open
vb-linetco wants to merge 4 commits intodanielzzz:masterfrom
Open
Add support for verifying reply addresses#172vb-linetco wants to merge 4 commits intodanielzzz:masterfrom
vb-linetco wants to merge 4 commits intodanielzzz:masterfrom
Conversation
--------- Co-authored-by: sa-linetco <sa-linetco@users.noreply.github.com>
vb-linetco
changed the title
Author
|
Hey @danielzzz , when you get a chance, could you please take a look at this PR? Let me know if you spot anything that needs changing. Thanks! |
Collaborator
|
Hi, after reading your implementation, can you rename the option to be A side note. I have update the underlying node engine. You may need to rebuild this project development accordingly. |
Author
|
@mondwan I've updated the PR as you requested. If there are any issues with my changes, please let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On linux platform when using ping from iptuils there is an issue when some misbehaving hosts or other network devices may respond to a ping with a different address. The ping implementation of
iputilsunfortunately regards those as valid replies and prints the timing information nevertheless see: comparison of source address with target and the corresponding statistics outputWe observed an issues with host being detected as alive when another misbehaving hosts replies to the echo requests. This PR Addresses the issue by adding an option to enable verification of reply addresses.