fix: Respect PAI_DIR environment variable in v4.0.3 installer#994
Open
sbusc wants to merge 1 commit intodanielmiessler:mainfrom
Open
fix: Respect PAI_DIR environment variable in v4.0.3 installer#994sbusc wants to merge 1 commit intodanielmiessler:mainfrom
sbusc wants to merge 1 commit intodanielmiessler:mainfrom
Conversation
The v4.0.3 installer hardcodes ~/.claude as the PAI directory in several places, ignoring the PAI_DIR environment variable. Users who set PAI_DIR to a custom path get a broken installation because the fallback always resolves to ~/.claude. Changes: - detect.ts: Read PAI_DIR from process.env when detecting system paths - actions.ts: Add PAI_DIR fallback in repository, configuration, and voice setup steps (3 locations) - validate.ts: Add PAI_DIR fallback in validation checks - install.sh: Pass through PAI_DIR if set, fix unbound variable errors for DISPLAY/WAYLAND_DISPLAY in headless detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v4.0.3 installer hardcodes
~/.claudeas the PAI directory in several fallback paths, ignoring thePAI_DIRenvironment variable. Users who setPAI_DIRto a custom path get a broken installation because detection, configuration, validation, and voice setup all fall back to~/.claudeinstead of respecting the env var.Changes
4 files in
Releases/v4.0.3/.claude/PAI-Install/:engine/detect.ts— ReadPAI_DIRfromprocess.envwhen detecting system pathsengine/actions.ts— Addprocess.env.PAI_DIRfallback in repository, configuration, and voice setup steps (3 locations)engine/validate.ts— Addprocess.env.PAI_DIRfallback in validation checksinstall.sh— Pass throughPAI_DIRif set; fix unbound variable errors forDISPLAY/WAYLAND_DISPLAYin headless detection (set -euo pipefailcompatibility)Test plan
bash install.shwithoutPAI_DIRset — should default to~/.claude(no behavior change)PAI_DIR=~/custom/.claude bash install.sh— should install to~/custom/.claudeDISPLAYset — should not error on unbound variable