Skip to content

ci: prevent duplicate runs on PRs, add Java 25 to matrix#160

Merged
danielflower merged 1 commit into
masterfrom
copilot/update-ci-build-settings
Apr 4, 2026
Merged

ci: prevent duplicate runs on PRs, add Java 25 to matrix#160
danielflower merged 1 commit into
masterfrom
copilot/update-ci-build-settings

Conversation

Copilot AI commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

CI was triggering twice for pull requests — once for the push event on the PR branch and once for the pull_request event.

Changes

  • Scoped push trigger to master only — PR branches now only trigger CI via pull_request, eliminating the duplicate run
  • Added Java 25 to the build matrix: [8, 11, 21, 25]
on:
  push:
    branches:
      - master
  pull_request:

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f4adcf5eb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yaml
Comment on lines +4 to +6
push:
branches:
- master

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Trigger CI on the repository's default branch

Limiting push to master means this workflow will not run for pushes/merges on repositories whose active branch is main (which is the branch present in this repo), so post-merge CI and any direct-push validation are silently skipped. This change prevents duplicate PR runs, but in a main-based repo it also removes the only push-event coverage for the default branch.

Useful? React with 👍 / 👎.

@danielflower danielflower merged commit 52d8407 into master Apr 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants