Skip to content

chore: prep v0.2 hardening branch for signing material hygiene#4

Open
daniel-p-green wants to merge 1 commit into
masterfrom
feature/skillvault-v0.2-hardening-env-prep
Open

chore: prep v0.2 hardening branch for signing material hygiene#4
daniel-p-green wants to merge 1 commit into
masterfrom
feature/skillvault-v0.2-hardening-env-prep

Conversation

@daniel-p-green

@daniel-p-green daniel-p-green commented Feb 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • add *.key and *.pem to .gitignore
  • prevent accidental commit of local private/public key material used during signing and verification work
  • keep repository hygiene aligned with upcoming SkillVault v0.2 trust/signing workflow tasks

Why

SkillVault v0.2 includes signed artifact and trust UX improvements. This branch prep ensures local cryptographic key files stay out of version control before broader hardening changes land.

Testing

  • git status --short --branch
  • git push -u origin feature/skillvault-v0.2-hardening-env-prep
  • verified only .gitignore changed in this PR

Summary by Sourcery

Chores:

  • Ignore local private/public key files (e.g., *.key, *.pem) in version control to maintain signing material hygiene.

@sourcery-ai

sourcery-ai Bot commented Feb 16, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

.gitignore is updated to exclude common cryptographic key files, preventing accidental commits of signing-related material for the SkillVault v0.2 hardening work.

File-Level Changes

Change Details Files
Exclude cryptographic key material from version control via .gitignore updates.
  • Add ignore pattern for files with .key extension
  • Add ignore pattern for files with .pem extension
  • Align ignore rules with upcoming SkillVault v0.2 signing and trust workflow needs
.gitignore

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Ignoring all *.key and *.pem globally might be too broad and could hide legitimate committed materials (e.g., test fixtures); consider scoping these patterns to specific directories (like a local signing workspace) or using more specific filenames to avoid unintended ignores.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Ignoring all `*.key` and `*.pem` globally might be too broad and could hide legitimate committed materials (e.g., test fixtures); consider scoping these patterns to specific directories (like a local signing workspace) or using more specific filenames to avoid unintended ignores.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@daniel-p-green

Copy link
Copy Markdown
Owner Author

Review note: This PR is a useful security hygiene prep (ignoring local key material), but it does not yet implement the scoped SkillVault v0.2 deliverables/acceptance criteria (US-001..US-006).\n\nTo satisfy the task scope, follow-up work should include: dogfooding harness + fixtures/reporting, stable error taxonomy with JSON output and remediation hints across commands, CLI UX and exit-code standardization, signed artifact verification flow docs/examples, determinism/performance checks, and documentation hardening.\n\nIf this PR is intentionally only env prep, please explicitly scope it as such and track the full v0.2 implementation in a separate PR with verification evidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant