Small-scale polishes and cleanups#2
Open
perimosocordiae wants to merge 1 commit into
Open
Conversation
Feel free to use any or all of these changes in v0.4 if you don't want to touch v0.3. I didn't change any behavior, but updated some cosmetics: - the print message now shows the (i) option. - the input carets now have a space before user input starts - some Python idioms (`while True`, `if some_string:`, generator comprehensions, etc) - the command for writing an image now says where the file was created - some string concatenation avoided by using `str.join` The last bullet should be an efficiency improvement. It's much faster to accumulate strings in a list and then join them all at once than to concatenate each one in a loop.
Owner
|
Just finally looking at this now. Thanks for the input. I have to concede that your changes are the better way. That said, I'll probably merge them in over the next day or two. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feel free to use any or all of these changes in v0.4 if you don't want to touch v0.3. I didn't change any behavior, but updated some cosmetics:
while True,if some_string:, generator comprehensions, etc)str.joinThe last bullet should be an efficiency improvement. It's much faster to accumulate strings in a list and then join them all at once than to concatenate each one in a loop.