Make Choice and CtOption be Hash#138
Open
dvdplm wants to merge 1 commit intodalek-cryptography:mainfrom
Open
Conversation
Author
|
One question I have is if making |
Contributor
|
What's the use case for I think all of these types, including and especially |
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While rare, sometimes it is convenient to use
CtOptionin hashmaps/sets. This PR suggests addingHashtoCtOptionandChoiceto allow that use case, see e.g.crypto-bigint::Checked.It also aligns with
std::option::Option, which is alsoHash.