Disambiguate GuiOpenCommsButton states in UI #2677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the button text to indicate why the button is disabled. This reduces ambiguity about why the "Open comms" button is disabled while on Strategic Map when comms are engaged outside of its view. - Hide the "Open comms" button entirely if the ship lacks a CommsTransmitter.
To accommodate hiding the comms button on Ops when a ship lacks a CommsTransmitter component, use a layout container for waypoint and comms buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strategic Map while comms is receiving a hail
Before: Button reads "Link to Comms", but is disabled even when a valid comms target is selected. No indication that the button is disabled because comms are already engaged.
After: Button reads "Transmitting..." to indicate that the button is disabled because comms are already engaged.
Ops on a ship without a CommsTransmitter
Before: Button is present and reads "Open Comms", but is disabled even when a valid comms target is selected. No indication that the button cannot be enabled because the ship lacks a comms transmitter.
After: Button is absent because the ship lacks a comms transmitter and therefore cannot open comms with other entities.