Use nicer glyphs for fold/unfold controls (#247)#255
Conversation
Replace the fold-bar control glyphs with cleaner Unicode triangles that double better without kerning tricks: ▶ → ⏵ (U+23F5) ▼ → ⏷ (U+23F7) ▶▶ → ⏵⏵ ▼▼ → ⏷⏷ The doubled ⏵⏵ / ⏷⏷ sit at even spacing in both Chrome and Firefox, so the .fold-icon `letter-spacing: -.2em` kerning hack (added for ▶▶/▼▼, issues #73/#153) is removed. Also swap the params-table disclosure-marker fallback strings ▸→⏵ (U+25B8→U+23F5) and ▾→⏷ (U+25BE→U+23F7). This is fallback-only: Chrome and Firefox resolve list-style-type to disclosure-closed/open (native marker), so the params marker is visually unchanged there. Tooltips and fold behavior are unchanged. dev-docs/message-hierarchy.md and the HTML snapshot are updated to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThis PR replaces fold/unfold UI glyphs (▶/▼, doubled ▶▶/▼▼, and params-table ▸/▾) with new ⏵/⏷ (U+23F5/U+23F7) glyphs throughout CSS, the transcript HTML template's client-side JS, Python comments, dev-docs, and regenerated test snapshots/docstrings. A previous letter-spacing kerning tweak for doubled glyphs is removed since the new glyphs space evenly without it. ChangesFold glyph swap
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #247.
Cosmetic: replace the fold-bar control glyphs with cleaner Unicode triangles that double better without kerning tricks.
Glyph mapping
Also the params-table disclosure-marker fallback: ▸ → ⏵ (U+25B8→U+23F5) and ▾ → ⏷ (U+25BE→U+23F7).
Notes
data-state/aria-expanded, never by reading a glyph back..fold-iconletter-spacing: -.2emworkaround (added for ▶▶/▼▼ Chrome kerning, CB's ideas scratchpad #73/Minor CSS clean-ups #153) is dropped — the new ⏵⏵/⏷⏷ space evenly natively in Chrome and Firefox.list-style-type: "\23F5"thendisclosure-closed; Chrome and Firefox resolve todisclosure-closed(native marker), so the params marker is visually unchanged there — ⏵/⏷ only render wheredisclosure-*is unsupported.dev-docs/message-hierarchy.mdand the HTML snapshot are updated to match.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation
Tests