Subscribe to all pyMC companion channels (emcomm, weather, etc.)#110
Merged
Conversation
_discover_all_companions now returns every companion from /api/companion/index instead of stopping at the first match. _run_source spawns one SSE task per companion so messages from emcomm, weather, and other channels are received alongside public. https://claude.ai/code/session_01E6BhzRJuivUEz7uxxoygHT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_discover_companiononly returned the first companion from/api/companion/index, so only one channel's SSE stream was ever opened_discover_all_companionswhich returns every companion the repeater has registered_run_sourcenow spawns one concurrent SSE task per companion, so emcomm, weather, and any other channels receive messages alongside public?companion=lock, that behavior is preserved (single task)Test plan
[meshcore] N companion(s) at <url>: <list>— should list all registered companions?companion=Xstill only subscribes to that one companionhttps://claude.ai/code/session_01E6BhzRJuivUEz7uxxoygHT
Generated by Claude Code