Skip to content

refactor(syllabus): split 749-line syllabus.qmd into _subfiles/#927

Open
d-morrison wants to merge 4 commits into
mainfrom
claude/intelligent-pascal-4kup7p
Open

refactor(syllabus): split 749-line syllabus.qmd into _subfiles/#927
d-morrison wants to merge 4 commits into
mainfrom
claude/intelligent-pascal-4kup7p

Conversation

@d-morrison

Copy link
Copy Markdown
Owner

What

Splits the 749-line chapters/syllabus.qmd into a thin parent + 18 named subfiles under _subfiles/syllabus/, addressing the one item deferred from the #912 review (review comment).

  • The parent is now a 99-line outline: front matter, the callout, the banner table, and one {{< include >}} per major section — every section heading stays in the parent.
  • Each major section's body moves to its own _sec-*.qmd (e.g. _sec-texts.qmd, _sec-homework.qmd, _sec-learning-resources.qmd, _sec-overview-table.qmd).
  • No subfile begins with a section heading, per CLAUDE.md.
  • Include path mirrors the established repo pattern (chapters/_subfiles../_subfiles symlink), matching Intro-to-GLMs.qmd.

Content is unchanged

This is a pure mechanical move. Expanding the includes reproduces the original document: diff -B is empty and all 563 non-blank lines match. No prose was reworded.

Checks (all pass)

  • Renderquarto render chapters/syllabus.qmd --to html succeeds; all headings and sampled body content (Texts/Stroup, Territory/Patwin, Homework/self-grade, both Employment sections) confirmed present in the HTML.
  • Lintlintr reports 0 issues on all changed files (they contain no R code).
  • Spellspelling::spell_check_package() → "No spelling errors found".

Notes

  • This branch was previously used for the (already-merged) CLAUDE.md change in docs(CLAUDE.md): watch PRs until merged/closed by default #917; that change is in main, so this PR's diff is only the syllabus split.
  • To render locally I had to git submodule update --init latex-macros (the latex-macros/ macros submodule was uninitialized in the fresh container — a pre-existing setup gap, not part of this change). No submodule pointer change is committed.
  • Touches _subfiles/, so the clear freezer label applies.

🤖 Generated with Claude Code


Generated by Claude Code

claude added 3 commits June 20, 2026 07:27
Add a Pull Requests convention: after opening or being asked to watch a
PR, subscribe to its activity and watch through to merge/close (confirm
CI, surface review comments, catch merge conflicts), re-arming a periodic
check-in and only pinging when the author is needed -- and back off the
moment the author asks.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UbqjCwkggGX5yFzXQSafhd
The syllabus had grown to 749 lines in a single .qmd, well over the
~100-line guideline in CLAUDE.md -- the one item deferred from the #912
review.

Move each major section's body into a named subfile under
_subfiles/syllabus/ (18 files, e.g. _sec-texts.qmd, _sec-homework.qmd,
_sec-learning-resources.qmd), keeping every section heading in the
parent so it now reads as a clean ~99-line outline of {{< include >}}
directives. No subfile begins with a section heading, per CLAUDE.md.

Content is unchanged: expanding the includes reproduces the original
document (diff -B empty; 563 non-blank lines match). The chapter renders
to HTML cleanly; lintr reports 0 issues on changed files (no R code) and
spelling::spell_check_package() finds no errors.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UbqjCwkggGX5yFzXQSafhd
Copilot AI review requested due to automatic review settings June 20, 2026 08:53
@github-actions github-actions Bot removed the request for review from Copilot June 20, 2026 08:53
@claude

claude Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Claude finished @d-morrison's task in 2m 28s —— View job


Code Review

  • Read all 18 subfiles and parent chapters/syllabus.qmd
  • Verified CLAUDE.md conventions
  • Checked CI status
  • Compiled findings

Overall verdict: LGTM with one action item (missing label).

This is a clean mechanical split. All CLAUDE.md structural conventions are satisfied. CI lint and spellcheck have both passed; the Quarto Preview Build is still running.


What's correct

Convention Result
No subfile begins with a section heading ✅ All 18 subfiles open with prose or a table
All #/## headings stay in parent ✅ Parent holds every heading; subfiles contain only body
Parent ≤ ~100 lines ✅ Exactly 99 lines
chapters/_subfiles → ../_subfiles symlink present ✅ Verified on disk
Include paths follow established pattern ✅ Matches Intro-to-GLMs.qmd convention
Files placed in _subfiles/syllabus/ ✅ Correct subdirectory

Action item

Missing "clear freezer" label — the PR description correctly notes "Touches _subfiles/, so the clear freezer label applies", but the label has not been applied. Per CLAUDE.md, it is required whenever _subfiles/ are edited. Please add it before merging.


Minor observations (not blocking)

_subfiles/syllabus/_sec-homework.qmd — 123 lines (CLAUDE.md guideline is ~100). The file has six subsections (### Homework Submission Format, ### Late Work, ### Collaboration, ### Artificial Intelligence, ### Homework Grading, ### Expected Study Workload). For a pure mechanical refactor this is reasonable; further splitting could be a follow-up if desired.

_subfiles/syllabus/_sec-texts.qmd, lines 44–72 — the two Kleinbaum & Klein books are listed twice: once in the main catalogue (lines 44–53) and again in the free-download paragraph (lines 62–72), with identical URLs. This is pre-existing content, not introduced by this PR, so no action needed here; just flagging for awareness.


Copilot AI review requested due to automatic review settings June 20, 2026 08:57
@github-actions github-actions Bot removed the request for review from Copilot June 20, 2026 08:58
@claude

claude Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Claude finished @d-morrison's task in 2m 21s —— View job


Code Review — PR #927 (syllabus split)

  • Read context and PR description
  • Read all 18 subfiles and modified parent chapters/syllabus.qmd
  • Check CLAUDE.md conventions
  • Check CI status
  • Final summary verdict

Overall verdict: LGTM

This is a clean, correct mechanical split. Every CLAUDE.md structural rule is satisfied and CI passes on lint and spellcheck.


CLAUDE.md convention checklist

Convention Result
No subfile begins with a section heading ✅ All 18 open with prose or a table
All #/## headings stay in the parent ✅ Parent holds every heading
Parent ≤ ~100 lines ✅ Exactly 99 lines
chapters/_subfiles → ../_subfiles symlink present ✅ Verified
Include paths follow established pattern ✅ Matches Intro-to-GLMs.qmd
Files placed in _subfiles/syllabus/
"clear freezer" label applied ✅ Already on the PR

CI status

Check Result
Spellcheck ✅ passed
lint-changed-files ✅ passed
Quarto Preview Build ⏳ in progress

Minor observations (non-blocking; pre-existing content)

_subfiles/syllabus/_sec-homework.qmd — 123 lines. The CLAUDE.md guideline is ~100. Six subsections (### Homework Submission Format, ### Late Work, ### Collaboration, ### Artificial Intelligence, ### Homework Grading, ### Expected Study Workload) make this the longest subfile. For a pure mechanical refactor this is fine; further splitting could be a follow-up if desired.

_subfiles/syllabus/_sec-texts.qmd — duplicate entries. The two Kleinbaum & Klein books appear twice: once in the main catalogue (lines 44–52) and again under the "free download" paragraph (lines 66–72), with identical URLs. Pre-existing content, not introduced here.


@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
🚀 Preview available at: https://d-morrison.github.io/rme/pr-preview/pr-927/

Built to branch gh-pages at 2026-06-20 09:17 UTC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants