CLAUDE.md: dual quarto config wiring + shared-checkout worktree note#915
Conversation
- New book pages must be wired into both _quarto-book.yml and _quarto-website.yml (the two profiles keep independent page lists) — a gotcha hit when adding the Course Logistics pages. - The checkout is shared by concurrent agent sessions; work in an isolated worktree off origin/main and reconcile origin/<branch> before pushing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
|
Claude finished @d-morrison's task in 1m 0s —— View job Code Review: PR #915
Both additions are accurate, well-motivated, and belong in CLAUDE.md. One substantive suggestion on the worktree bullet; the rest is minor. File Structure addition ( Pull Requests addition ( When resuming an existing PR branch (the more common agent pattern), Without this distinction, an agent following the instruction literally on a resume task will create a fresh branch from The "reconcile These are suggestions, not blockers — the current text is already a meaningful improvement over nothing. Happy to approve as-is or with a quick tweak to the worktree example. |
Per @claude review on #915: the worktree example only covered new branches; add the resume-an-existing-PR-branch form, and note 'git fetch then merge or rebase' for the pre-push reconcile. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
|
Addressed both suggestions in the latest push:
Both were non-blocking suggestions; folded them in. Waiting on the push-triggered review. |
|
Claude finished @d-morrison's task in 2m 55s —— View job Code Review: PR #915 (follow-up)
Both prior suggestions have been addressed. One small technical nit on the resume worktree command, and an observation about sentence flow. File Structure addition — Factually correct ( Pull Requests addition — what changed — The two new cases are well-motivated and the reconcile hint is now actionable. One nit: The resume-branch flag order is inconsistent with the new-branch form in the same sentence: Git's permissive argument parsing means this will likely work, but the inconsistency within a single sentence is a readability stumble. The resume form should follow the same convention as the new-work form: Sentence flow — The Overall: These are both genuine additions and both prior suggestions were addressed. The flag-order inconsistency is the only thing that might trip an agent copying the command literally — worth a one-word fix ( |
Per @claude review on #915: make the resume worktree command use the same '-b <branch> <dir> origin/...' flag order as the new-work form, and move the 'git submodule update --init' step after the commands for clearer flow. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
|
Addressed both nits in the latest push: the resume worktree command now uses the same |
There was a problem hiding this comment.
Pull request overview
Updates CLAUDE.md with two repository-specific “gotchas” to prevent common Quarto wiring mistakes and reduce risk when multiple agent sessions share the same checkout.
Changes:
- Document that new pages must be added to both
_quarto-book.ymland_quarto-website.yml(including the websiterender:list and navbar). - Add guidance to use isolated
git worktrees in shared checkouts, including commands for new work vs. resuming an existing PR branch.
| - Link to `.qmd` source files, not rendered `.html` files | ||
| - Aim to keep `.qmd` source files under ~100 lines; split longer files into named subfiles in `_subfiles/` | ||
| - `_extensions/` is vendored third-party code — do not review or modify it | ||
| - New book pages must be wired into **both** `_quarto-book.yml` (book/PDF TOC, incl. its `part:` groupings) **and** `_quarto-website.yml` (the default website profile: the `render:` list **and** the navbar) — the two profiles keep independent page lists, so a page added to only one is missing from the other build |
| - Verify all changed hyperlinks before requesting review | ||
| - If any `_subfiles/` were edited, add the "clear freezer" label | ||
| - Workflow / `.github/` / CI / infra changes go in their own dedicated PRs — never mix them with book-content PRs | ||
| - This checkout is often shared by concurrent agent sessions — the branch can switch under you, and commits land on PR branches from other sessions or the `@claude` bot. Work in an isolated `git worktree`: for **new** work `git worktree add -b <branch> <dir> origin/main`; to **resume** an existing PR branch `git worktree add -b <branch> <dir> origin/<branch>` (the `origin/<branch>` start point picks up the PR rather than starting a fresh branch from `main`). Then run `git submodule update --init` in the new worktree. Before every push, `git fetch` and reconcile `origin/<branch>` (merge or rebase) — another session may have already pushed the same change |
…otes # Conflicts: # CLAUDE.md
|
Claude finished @d-morrison's task in 2m 17s —— View job Code Review: PR #915 (round 3)
One real correctness issue remains in the resume-branch command; the File Structure addition is clean. File Structure addition — Accurate and actionable. The long single-line bullet is noted by copilot as conflicting with the "one source line per major phrase" convention (line 47), but looking at the existing file, several other list items (e.g. the model-structure bullet) are similarly long single lines, so this isn't a new pattern. Low severity, not blocking. Pull Requests addition — resume command ( The resume-branch form still reads:
The robust fix is This was the substance of the copilot reviewer's second comment. Previous rounds of review addressed flag order (position of Overall: The File Structure bullet is good to merge as-is. The Pull Requests bullet is a one-char fix ( |
Per @claude/copilot review on #915: lowercase -b fails if the local branch already exists (the normal resume case in a shared checkout). Use -B, which creates-or-resets the branch to origin/<branch>. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Genuine one-char correctness fix this round (not style). Waiting on the re-review. |
|
👀 Picked up by workflow run #27865878030. R/Quarto/renv setup runs first (~3-5 min); Claude itself responds after that. |
…docs/claude-md-repo-notes # Conflicts: # CLAUDE.md Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
|
Claude finished @d-morrison's task in 2m 11s —— View job Code Review: PR #915 (round 4)
Both prior findings from round 3 have been addressed. The PR is clean. File Structure addition — Both Pull Requests addition — The one remaining correctness issue (
No remaining issues. Ready to merge. |
Two small CLAUDE.md additions capturing repo-specific gotchas from recent work (relocating them here, where they belong, rather than a general notes repo):
_quarto-book.ymland_quarto-website.yml; the two profiles keep independent page lists. (Hit while adding the Course Logistics pages in Add Course Logistics part: Spring 2026 syllabus and schedule #912 — a page added to only one profile is missing from the other build.)@claudebot), so work in an isolatedgit worktreeofforigin/mainand reconcileorigin/<branch>before pushing.Docs-only; no code or workflow changes.
🤖 Generated with Claude Code