CLAUDE.md: add ~100-line source file length convention#910
Conversation
Adds a File Structure guideline to keep source files under ~100 lines and split longer files into named subfiles, matching the decomposition practice requested in review and applied in PR #843. Kept as its own dedicated PR per the CLAUDE.md rule that meta/infra changes don't mix with book-content PRs. https://claude.ai/code/session_01NQSLJmjMN22RpwpgJ6Lw6u
|
Claude finished @d-morrison's task in 48s —— View job Code Review
Overall verdict: The change is correct and achieves its stated goal cleanly. Two minor clarity suggestions below. CLAUDE.md line 39 (new line): Finding 1 — Scope ambiguity: "source files" is unqualified, but the surrounding bullets are all Finding 2 — "named subfiles" is slightly vague: The project already has a well-established Both are non-blocking suggestions. The change as written is still accurate and useful. |
Address review on #910: qualify 'source files' as '.qmd' (a 100-line cap is too tight for R package code in R/), and name the established _subfiles/ directory as the split target. https://claude.ai/code/session_01NQSLJmjMN22RpwpgJ6Lw6u
|
Claude finished @d-morrison's task in 1m 44s —— View job Code Review
Overall verdict: The change is correct, cleanly scoped, and ready to merge. Both findings from the prior review have been resolved by commit CLAUDE.md, line 39 (added): Prior findings — now resolved:
One non-blocking suggestion — bullet ordering: The File Structure section currently reads: The new bullet references |
|
Claude finished @d-morrison's task in 1m 45s —— View job Code Review
Overall verdict: The change is correct, minimal, and achieves its stated goal. The PR is already merged. No blocking issues found. The change — Findings: No blocking issues. One non-blocking cosmetic note: Bullet ordering (cosmetic): The File Structure section now reads: Bullets 1 and 3 both reference Note: No inline review comment tool was available in this session, so findings are posted here rather than as line-level PR comments. |
Summary
Adds a single File Structure guideline to
CLAUDE.md:Why
A review on #843 requested (1) decomposing the 462-line
_sec_double_integrals.qmdinto focused subfiles, and (2) recording the ~100-line size convention inCLAUDE.md.The decomposition is handled in #843. This convention change is kept in its own dedicated PR per the
CLAUDE.mdrule that "Workflow / .github / CI / infra changes go in their own dedicated PRs — never mix them with book-content PRs."Scope
One-line documentation change to
CLAUDE.md; no.qmd/.R/content touched, so no render/lint/spell run is required.https://claude.ai/code/session_01NQSLJmjMN22RpwpgJ6Lw6u
Generated by Claude Code