CLAUDE.md: merge main on branch pickup, not just before push#902
Conversation
|
Claude finished @d-morrison's task in 51s —— View job Code Review
Overall: Clean, well-targeted improvement. The reasoning is sound — catching a stale base at pickup is cheaper than catching it at push time. No correctness issues. One minor note ( No other issues found. |
Addresses review nit on #902: 'when picking it up' read as resuming only; 'starting or resuming work on it' makes clear it covers newly created branches too.
|
Claude finished @d-morrison's task in 59s —— View job Code Review
Overall: Clean improvement. The previous nit ("
One optional style nit: three em-dash clauses in a single bullet makes it a bit dense. Splitting into two bullets could improve scannability: This is purely cosmetic; the single-line form is clear and correct as-is. Not a blocker. No other issues found. ✓ |
Clarified instructions on merging main into feature branches and added a note about verifying hyperlinks.
|
Claude finished @d-morrison's task in 1m 5s —— View job Code Review
Overall: Ready to merge. Both prior nits are addressed — the two-bullet split resolves the em-dash density nit from the second review, and "starting or resuming" (already landed in an earlier commit) resolves the ambiguity nit from the first. The No issues found. ✓ |
Summary
Strengthens the "merge main" rule in CLAUDE.md to require it at branch pickup, not just before pushing. Catches stale-base issues at the start of work, when they're cheapest to resolve.
Companion to #897 (merge-before-push) and #901 (URL inclusion).
Generated by Claude Code