Skip to content

CLAUDE.md: merge main on branch pickup, not just before push#902

Merged
d-morrison merged 3 commits into
mainfrom
claude/rule-merge-main-on-pickup
Jun 13, 2026
Merged

CLAUDE.md: merge main on branch pickup, not just before push#902
d-morrison merged 3 commits into
mainfrom
claude/rule-merge-main-on-pickup

Conversation

@d-morrison

Copy link
Copy Markdown
Owner

Summary

Strengthens the "merge main" rule in CLAUDE.md to require it at branch pickup, not just before pushing. Catches stale-base issues at the start of work, when they're cheapest to resolve.

Companion to #897 (merge-before-push) and #901 (URL inclusion).


Generated by Claude Code

@claude

claude Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Claude finished @d-morrison's task in 51s —— View job


Code Review

  • Read diff and context
  • Review change

Overall: Clean, well-targeted improvement. The reasoning is sound — catching a stale base at pickup is cheaper than catching it at push time. No correctness issues.

One minor note (CLAUDE.md line 71): The phrase "when picking it up" most naturally reads as resuming existing work rather than creating a new branch. If Claude also creates branches (not just resumes them), "when starting or resuming work on it" would be slightly more explicit. As written it's unambiguous enough in context, so this is purely a nit — not a blocker.

No other issues found.


Addresses review nit on #902: 'when picking it up' read as resuming
only; 'starting or resuming work on it' makes clear it covers newly
created branches too.
@claude

claude Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Claude finished @d-morrison's task in 59s —— View job


Code Review

  • Read diff and context
  • Review change
  • Post findings

Overall: Clean improvement. The previous nit ("when picking it up could mean only resuming, not starting fresh") has been addressed — "when starting or resuming work on it" is unambiguous.

CLAUDE.md line 71 — the new sentence is:

Always merge main into the feature branch when starting or resuming work on it — and again before pushing — not just before requesting review

One optional style nit: three em-dash clauses in a single bullet makes it a bit dense. Splitting into two bullets could improve scannability:

- Always merge `main` into the feature branch when starting or resuming work on it
- Merge `main` again before pushing — not just before requesting review

This is purely cosmetic; the single-line form is clear and correct as-is. Not a blocker.

No other issues found. ✓

Clarified instructions on merging main into feature branches and added a note about verifying hyperlinks.
@d-morrison d-morrison marked this pull request as ready for review June 13, 2026 20:30
@claude

claude Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Claude finished @d-morrison's task in 1m 5s —— View job


Code Review

  • Read diff
  • Review change
  • Post findings

Overall: Ready to merge. Both prior nits are addressed — the two-bullet split resolves the em-dash density nit from the second review, and "starting or resuming" (already landed in an earlier commit) resolves the ambiguity nit from the first.

The again in the second bullet is a nice touch: it implicitly signals that the pickup merge already happened, making the before-push requirement feel like a natural follow-up rather than a standalone rule.

No issues found. ✓

@d-morrison d-morrison merged commit c9c6c52 into main Jun 13, 2026
3 of 4 checks passed
@d-morrison d-morrison deleted the claude/rule-merge-main-on-pickup branch June 13, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants