Title every definition and result callout (base for #872 diagram)#875
Conversation
Every definition and result callout (def/thm/lem/cor/prp) now has a concise `#### Title` as its first inner line, so each renders as "Definition N (Title)" and is easy to refer to. This titles the 89 previously-untitled callouts across 38 files, leaving 0 untitled of the 434 result callouts in the notes. This is the base of a two-PR stack for #872: this PR gets every definition and result into self-describing div form; the stacked PR builds the relationship diagram and descendants table on top. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
|
Claude finished @d-morrison's task in 5m 13s —— View job Code Review — PR #875
SummaryThis is a well-executed mechanical PR. All 89 new titles are accurate noun-phrase descriptions of their callouts' mathematical content, and an automated search confirms the PR's claim: 0 untitled Below are a few issues worth addressing before merging, ordered by severity. Issues1. Inline LaTeX in titles will break diagram node labels (PR #873) — medium priorityTwo titles contain inline LaTeX:
Since PR #873 derives node and table labels directly from these 2.
|
2026-06-03 18:21 UTC |
New appendix `chapters/concept-map.qmd` visualizes how every definition and result in the notes depends on the others: - a color-by-type dependency diagram, with node size proportional to the number of descendants so the most foundational results stand out, and - a table listing each result's direct and indirect descendants (live `@ref` cross-reference links), sorted by number of direct descendants. The graph is built by `data-raw/callout-graph.R`, which scans the `.qmd` sources and saves the result to `inst/extdata/callout-graph.rds`. The appendix reads that saved artifact, so the scan does not re-run on every render — re-run the script when divs are added, removed, or re-titled. References are attributed to the enclosing callout, or to the callout an immediately-following proof/solution div belongs to; references that aren't inside a result (plain prose) don't create edges. Stacked on the title-audit PR (#875), which gives every node a concise label. Registered as the final appendix in the book and website configs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Base PR of a two-PR stack addressing #872.
What this PR does
Adds a concise
#### Titleto every previously-untitleddef/thm/lem/cor/prpcallout, so each one:This covers point 3 of #872 ("make sure all definitions and results are in divs, and each div has a concise title"). It titles 89 previously-untitled callouts across 38 files, leaving 0 untitled of the 434 result callouts in the notes. The titles are content-derived noun phrases following the existing house convention (a
####heading as the div's first inner line).Why split it out
The stacked PR (#873) builds the relationship diagram and descendants table for #872. Those node/table labels come straight from these titles, so getting every result into self-describing div form first keeps that PR focused on the graph code and keeps this large-but-mechanical titling diff reviewable on its own.
Checks
quarto render✅ — all 11 affected parent chapters render clean(
basic-statistical-methods,probability,algebra,poisson,negbinom,parametric-survival-models,logistic-regression,proportional-hazards-models,intro-to-survival-analysis,intro-MLEs,Linear-models-overview)lintr✅ — no new findings (7 pre-existing findings remain in R chunks not touched here)spelling::spell_check_package()✅ — cleanStacked PR for the diagram + table: to follow, based on this branch.
🤖 Generated with Claude Code