Skip to content

Refresh CLAUDE.md to current repo state#125

Open
d-morrison wants to merge 3 commits into
mainfrom
claude/claude-md-docs-nbeq7n
Open

Refresh CLAUDE.md to current repo state#125
d-morrison wants to merge 3 commits into
mainfrom
claude/claude-md-docs-nbeq7n

Conversation

@d-morrison

Copy link
Copy Markdown
Owner

Conservative refresh of the root CLAUDE.md to match the repo's current state. No wholesale rewrite; existing structure and voice preserved, and it still points to .github/copilot-instructions.md as the style source of truth.

Changes:

  • Repository layout: add references.qmd, the reveal.js slide files (styles-reveal.scss, qwt-reveal-toggle.html, revealjs-*.lua), assets/, images/, .github/instructions/, and CONTRIBUTING.md.
  • CI: align the listed checks with the workflows that actually run — add bibliography-DOI and non-standard-character checks alongside spell/link/lint.
  • Note that Dependabot auto-updates the macros submodule and GitHub Actions, so those shouldn't be bumped by hand.

All additions were verified against the working tree and config (_quarto.yml reveal output, _quarto-website.yml references.qmd, .github/dependabot.yml).

🤖 Generated with Claude Code

https://claude.ai/code/session_012P5jndYuYhLVGPp1e9CEcp


Generated by Claude Code

Round out the repository layout (reveal.js slide files, references.qmd,
assets/images, .github/instructions, CONTRIBUTING.md) and align the CI-check
references with the workflows that actually run (bibliography DOIs,
non-standard chars), plus note Dependabot manages the macros submodule and
GitHub Actions.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012P5jndYuYhLVGPp1e9CEcp
Copilot AI review requested due to automatic review settings June 20, 2026 22:04
@claude

claude Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Review in progress

  • Gather context
  • Read diff and current CLAUDE.md
  • Verify claimed file/workflow additions exist in the repo
  • Post review findings

View job run

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refreshes the root CLAUDE.md to accurately reflect the repository’s current structure and CI automation, keeping it aligned with the repo’s existing conventions and pointing to .github/copilot-instructions.md as the style source of truth.

Changes:

  • Updates the repository layout section to include newly present content and configuration paths (e.g., references.qmd, reveal.js support files, assets/, images/, .github/instructions/, CONTRIBUTING.md).
  • Updates the CI section to list additional checks that run in this repo (bibliography DOI validation and non-standard character checks).
  • Notes that Dependabot manages updates for the macros submodule pointer and pinned GitHub Actions.

Comment thread CLAUDE.md Outdated
references.qmd is excluded from the website render list (!references.qmd in
_quarto-website.yml), so list it separately with that caveat rather than
alongside the normally-rendered source pages. Per Copilot review on PR #125.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012P5jndYuYhLVGPp1e9CEcp
@claude

claude Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Claude finished @d-morrison's task in 2m 6s —— View job


Code review complete

  • Gather context
  • Read CLAUDE.md diff
  • Verify claimed file/workflow additions exist in the repo
  • Post review summary

Review summary

Clean — ready to merge. All claims in the PR description were verified against the working tree:

Addition Verified
references.qmd (with exclusion note) ✓ exists; !references.qmd confirmed in _quarto-website.yml
styles-reveal.scss, qwt-reveal-toggle.html, revealjs-*.lua ✓ all exist; lua filters confirmed in _quarto.yml
assets/, images/ ✓ both exist
.github/instructions/ ✓ exists; path-scoped description matches copilot-instructions.md
CONTRIBUTING.md ✓ exists (contributor guide)
check-bibliography-dois.yml, check-non-standard-chars.yaml ✓ both exist under .github/workflows/
.github/dependabot.yml ✓ exists

The copilot reviewer's concern about references.qmd missing the exclusion note was already addressed in commit 592f267. The revealjs-* glob in the layout description correctly covers both revealjs-html-links.lua and revealjs-level1-slide-breaks.lua.

One minor observation (not blocking): the assets/ directory currently holds PR screenshots (assets/pr-screenshots/) used in CI documentation, and images/ is a template placeholder (README only). The description "static assets used by pages and docs" is a reasonable shorthand, but "pages and docs" slightly overstates assets/ — it's CI/PR docs, not site pages. Not worth a revision on a template repo where these directories are expected to fill with real content downstream.

assets/ currently holds CI/PR screenshots, so describe these dirs as static
image/asset files for pages, docs, and CI rather than implying site pages
only. Per review on PR #125.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012P5jndYuYhLVGPp1e9CEcp
@claude

claude Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Claude finished @d-morrison's task in 1m 44s —— View job


Review complete

  • Gather context
  • Read CLAUDE.md diff
  • Verify claimed file/workflow additions exist in the repo
  • Post review findings

Clean — ready to merge.

All additions were verified against the working tree:

Claim Verified
references.qmd exists; excluded via !references.qmd in _quarto-website.yml
styles-reveal.scss, qwt-reveal-toggle.html, revealjs-*.lua (two filters) ✓ in root; lua filters confirmed in _quarto.yml
assets/, images/ ✓ both exist
.github/instructions/ (two .instructions.md files)
CONTRIBUTING.md
check-bibliography-dois.yml, check-non-standard-chars.yaml ✓ under .github/workflows/
.github/dependabot.yml (gitsubmodule + github-actions) ✓ matches description exactly

No issues found. The references.qmd copilot concern from the prior round was correctly addressed in 592f267. The revealjs-* glob matches both revealjs-html-links.lua and revealjs-level1-slide-breaks.lua as expected.

@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://d-morrison.github.io/qwt/pr-preview/pr-125/

Built to branch gh-pages at 2026-06-20 15:15 PDT.
Preview will be ready when the GitHub Pages deployment is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants