Fix intermittent crashes in speech/audio pipeline#2
Open
kirill-jjj wants to merge 4 commits intocyrmax:masterfrom
Open
Fix intermittent crashes in speech/audio pipeline#2kirill-jjj wants to merge 4 commits intocyrmax:masterfrom
kirill-jjj wants to merge 4 commits intocyrmax:masterfrom
Conversation
Remove UB in resampler frame count handling, initialize device state safely, validate audio metadata, and add fallback device index 0 handling.
Handle null SRAL buffers and invalid audio metadata, and propagate playback result from Audio::playAudioData instead of always returning success.
Prevent out-of-range voice and device selections, handle empty voice list, and normalize invalid device selection to index 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Speech::speak0Details
ma_device_id0Commits
fix: harden audio pipeline and device selectionfix: validate SRAL output before audio playbackfix: guard ui voice/device selection indices