Skip to content

Forbid non-numeric input to be treated as an integer #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lorcan wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −3
Open

Forbid non-numeric input to be treated as an integer #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56bc47f
Added a failing test for bad integer parsing
lorcan Apr 25, 2016
d68c093
Added logic to forbid non-numeric input to be treated as an integer
lorcan May 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/mutations/integer_filter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,12 @@ def filter(data)

# Ensure it's the correct data type (Integer)
if !data.is_a?(Integer)
if data.is_a?(String) && data =~ /^-?\d/
data = data.to_i
if data.is_a?(String)
begin
data = Integer(data)
rescue ArgumentError
return [data, :integer]
end
else
return [data, :integer]
end
Expand Down
2 changes: 1 addition & 1 deletion spec/integer_filter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

it "doesnt't allow other strings, nor does it allow random objects or symbols" do
f = Mutations::IntegerFilter.new
["zero","a1", {}, [], Object.new, :d].each do |thing|
["zero", "6iamnotanumber", "a1", {}, [], Object.new, :d].each do |thing|
_filtered, errors = f.filter(thing)
assert_equal :integer, errors
end
Expand Down