Don't use GNOME's custom title bar

[pierrelasse]

Old ugly:

(Hopefully) fixed nicer looking:

Lmk if this is the correct file.

Issue about the issue: flutter/flutter#111453

Here is someone else doing it interstellar-app/interstellar@51956c3

[julian-CStack]

The file is correct, however main branch is a ways behind staging and making this exact change there may break the change added to address #1211 I think.

I'm not familiar enough with how gtk works across various linux environments to say for sure whether this change will break things elsewhere.

One more note: As this is a "template" file, the window title value should be left as 'PlaceHolderName' and https://github.com/cypherstack/stack_wallet/pull/1248/files#diff-293e8fb5d4eaabd128db2623823372c106b27c53a1e98a882ad639840713af83L101 should be left unchanged.

I will leave this PR open as it does look a lot better but it needs some tweaks and testing (or someone who knows more about gtk to chime in).

[pierrelasse]

I'm not familiar enough with how gtk works across various linux environments to say for sure whether this change will break things elsewhere.

From what I know, this breaks nothing. On GTK, it just makes the bar a bit smaller from what I know. (will edit this once I know it)
It should look like this on GNOME with this change.

As this is a "template" file, the window title value should be left as 'PlaceHolderName'

Where is this template used? So an application id can be set to improve support.

[julian-CStack]

I did a brief bit of digging and that "application-id" seems to be a key if I am not wrong and the value is APPLICATION_ID which is set in a cmakelists.txt. I followed that back to some config scripts and did find that we indeed did not properly set this. Thanks for bringing this up as I was able to fix it with 0b2b797

Regarding the title bar, the title string is configured before compile time so that should not be changed here. As I mentioned previously, I agree with the better looks of the smaller/thinner title bar and the change #WorksOnMyMachine. But not everyone runs Ubuntu with GNOME and we've had various issues in the past with different distros, so without testing on a bunch of different systems this is a change I'm hesitant to add at the moment.

[pierrelasse]

Can you maybe approve the workflow so we can get a version we can perform these tests with?

[julian-CStack]

I've updated the base branch according to my first message re staging branch. I think the workflow will fail currently regardless (due to unrelated issues) but that won't stop you from building a version to test with.