Add Support for Firo Masternode Creation#1240
Closed
cassandras-lies wants to merge 3 commits intocypherstack:stagingfrom
Closed
Add Support for Firo Masternode Creation#1240cassandras-lies wants to merge 3 commits intocypherstack:stagingfrom
cassandras-lies wants to merge 3 commits intocypherstack:stagingfrom
Conversation
cassandras-lies
force-pushed
the
firo-masternode-control
branch
from
cd8ab19 to
f16250c
Compare
Collaborator
|
cherry picked relevant commit and merged as part of #1244 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Firo masternode creation. It doesn't support updating, so you need to break the masternode via coin control, send to self, and remake it for that. (Updating requires a BLS signature which uses a large outdated library I didn't want to pull in.)
This includes a DO NOT MERGE commit which includes julian-CStack/coinlib#3 to support the masternode transactions. That should be merged upstream and the DO NOT MERGE commit rebased out.