fix: Handle empty array binding in Bash 3.x in MacOS#2
Closed
abhisek wants to merge 2 commits into
Closed
Conversation
Contributor
|
merged with #1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
./install.shfailed on macOS with:A fresh install has no Claude profiles yet, so the alias list is empty. macOS still ships bash 3.2, where expanding an empty array as
"${arr[@]}"underset -uis treated as an unbound variable and aborts. Bash 4+ (so Linux) doesn't do this, which is why it only bit Mac users — on the very first command they run.The fix
Guard every dynamically-built array that can legitimately be empty with
"${arr[@]+"${arr[@]}"}", which expands to nothing when empty instead of erroring. The duplicatedcompose … execcall is folded into oneaidc::compose_exechelper so the guard lives in a single place. Arrays that are never empty are left as-is, so the guard now reads as "this one can be empty."Tests
New
aidc-e2e.ymlexercises the install and common CLI paths on both Ubuntu and macOS runners. The macOS leg is pinned to the system bash 3.2 (and asserts it took effect), so this can't quietly regress.