Refine UI Implementation & Refine DB Revamped#9
Conversation
Thanks to @cydh
Thanks to @anity99
Added a new configuration values in the YAML configuration to mark if a material will break or downgrade the item in case of failure.
… to @ecdarreola Signed-off-by: Cydh Ramdh <cydh@pservero.com>
* Enabled Blacksmith Blessing check for refining to disable downrefine on fail! (of course without breaking the refined item) * +7 to +8 needs 1 ea * +8 to +9 needs 2 ea * +9 to +10 needs 4 ea * +10 to +11 needs 7 ea * +11 to +12 needs 11 ea * Added Blacksmith Blessing entries to refine_db.yml follow the values above. * Fixed refine_info clearances on loading files. Signed-off-by: Cydh Ramdh <cydh@pservero.com>
* HD Oridecon & HD Elunium only can be used to update equip with refine level +7 to +9. It means +7 -> +8, +8 -> +9, +9 -> +10. * Enriched Oridecon & Enriched Elunium are just replacement of normal materials. It means only can be used to refine up to +10. * Corrected `true = enriched` flag for `getequippercentrefinery` commands. HD just simply use normal rates, not enriched. Or create new value for HDs later Signed-off-by: Cydh Ramdh <cydh@pservero.com>
* You are now allowed to add your own refine costs/chances! * Say goodbye to `event_refine_chance` config. If you need 'event'-like chance, just add the chance value and use that type for `getequippercentrefinery` command, just like its bro `getequiprefinecost`. * To disable certain refine material (based on refine cost/type) on certain refine level/type, just remove its value from it! * The most important,see your refine_db.yml now, the refine rates are using refine cost types. If you have custom values, just simply adjust it. * There are Blessed Oridecon/Elunium from `blessed_refiner` NPC to refine_db.yml but it won't be displayed in NEW Refine UI, why? Because the `RefineUI` value in refine_db.yml is set as `false`. * technically Over +10 is 'normal' rates, just have different material, so the `REFINE_COST_NORMAL` never be in +11 to +20 so does `REFINE_COST_OVER10` will never be in below +10. There are also HD, Enriched, and Blessed ores with this refine level restriction. Signed-off-by: Cydh Ramdh <cydh@pservero.com>
* Merge remote-tracking branch 'origin/refactor/refine_db' into refactor/refine_db * WIP refactor refine_db.yml processing (reverted in this commit)
* Removed 'Breakable' * Added 'OnFail' * 'Break' is percentage number to break the equip on fail, 100 = 100% * 'DownRefine' is percentage number to downrefine the equip on fail, 100 = 100% (checked after 'Break' chance if passed) * 'DownRefineNum' is number of down refine
|
@cydh how do I pull this to master? Would like to try this PR |
|
u can add new remote for my this repo, fetch it, merge to master or just apply the https://github.com/cydh/rathena/pull/9.diff |
|
@cydh How do I download the patch? |
|
just CTRL+S the .diff page file |
|
@cydh is this not possible via pull? its much easier there so I can always update if you have update too. |
add a new remote, fetch the branch, checkout it (I'm not teaching basic git usage, sorry) |
|
Wooow thanks @cydh <3 |
# Conflicts: # npc/re/merchants/hd_refiner.txt
|
after applying this, whenever I put any equipment to head the game crash the client. #edit: |
|
@admkakaroto it's must because you applied it wrong |
|
@cydh Can I use this PR? I saw the PR of Lemon, but do not have the blacksmith blessing, could you use this one here? |
* Added command `refineui select [item_index]` * Added command `refineui refine [item_index] [material_id] [catalyst_toggle]` * References: * rathena/rathena#2494 * cydh/rathena#9 * Tested using rAthena's PACKETVER 20161207
|
By using the 'feature.refineui: 2' option I am getting this message: Msg: [Warning]: conf/battle/feature.conf refine UI is enabled in scripts but disabled in general, enabling... |
|
hello @cydh , could you update this PR to the lastest version of rA? |
|
Can you update this @cydh ? thanks! |
|
just updated this PR |
|
Please update Holink and Wagjak from rathena@a12c79f |
|
i saw new 'master' not match to this change... is there any update soon?? thanks |
|
I'll update/rebase this messed up branch this weekend |
|
thanks for your good work |
|
Thank you for using this PR, I will close this since the commits are in a mess and move to #10 |
* Update and correction in item_db and item_combo_db Thanks to Edward Luciano # 1568 Thanks to 🅺🅸🅽🅶🅰🆁🆃🅴🆁 # 4210 Co-Authored-By: crazyarashi <meganekiho@gmail.com>
7 participants
Uh oh!
There was an error while loading. Please reload this page.