Draft
Conversation
These tests verify against the following fields, selectable by `dmidecode -s` - system-manufacturer - sytem-product-name - system-version - system-serial-number - system-uuid - system-sku_number - system-family - chassis-asset-tag The ladder is also verified within /sys/devices/virtual/dmi/id/chassis_asset_tag On-behalf-of: SAP leander.kohler@sap.com Signed-off-by: Leander Kohler <leander.kohler@cyberus-technology.de>
phip1611
requested changes
Feb 5, 2026
Member
phip1611
left a comment
phip1611
left a comment
There was a problem hiding this comment.
very nice first contribution to this repo :) Left a few remarks
| @@ -66,6 +66,7 @@ nixpkgs.lib.nixosSystem { | |||
| environment.systemPackages = with pkgs; [ | |||
| screen | |||
Member
There was a problem hiding this comment.
please use alphabetical ordering
| @@ -29,6 +29,14 @@ let | |||
| all_static_bdf ? false, | |||
| # Whether we add a function ID to specific BDFs or not | |||
| use_bdf_function ? false, | |||
Member
There was a problem hiding this comment.
I think this could be written more idiomatic using
smbios ? {
system_product_name = null;
system_version = null;
system_serial_number = null;
system_uuid = null;
system_sku_number = null;
system_family = null;
chassis_asset_tag = null;
},Nix hasn't types but I think this would be a pragmatic approach
| <type arch='x86_64'>hvm</type> | ||
| ${ | ||
| if | ||
| smbios_system_manufacturer != null |
Member
There was a problem hiding this comment.
you could create a helper function for that:
anySmbios = attrs: attrs.system_manufacturer != null || `
if anySmbios smbios then| </os> | ||
| ${ | ||
| if | ||
| smbios_system_manufacturer != null |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests verify against the following fields, selectable by
dmidecode -sThe ladder is also verified within
/sys/devices/virtual/dmi/id/chassis_asset_tag