forked from cloud-hypervisor/cloud-hypervisor
-
Notifications
You must be signed in to change notification settings - Fork 2
Add Support for Migration Statistics API Call #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
phip1611
wants to merge
11
commits into
cyberus-technology:gardenlinux
Choose a base branch
from
phip1611:poc-migration-statistics
base: gardenlinux
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9e3c2ed
vmm: silence some messages in http_endpoint
phip1611 51edb7c
vmm: improve logging of ongoing live-migrations
phip1611 0ccfecf
vm-migration: prepare progress types for new API endpoint
phip1611 35f6651
vmm: add migration-progress API endpoint
phip1611 440039c
vmm: add migration-progress HTTP endpoint
phip1611 af9eb95
vmm: prepare migration code for migration progress reporting
phip1611 3ea3e7d
vmm: actually populate migration progress
phip1611 056e53c
vmm: remove unnecessary Result
phip1611 d86cd81
ch-remote: add migration-progress command
phip1611 66bcec8
vmm: migration: switch to non-blocking SendMigration call
phip1611 f66f9ca
ch-remote: wait for migration to finish by querying migration progress
phip1611 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want that? As far as I know
ch-remoteis just a tool that makes using the REST API easier, thus I would expect that it behaves like the REST API. If I understand correctly, you don't even give the user the possibility to not see the statistics etc. when usingch-remote?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would have to be discussed with upstream. I have a tendency to handle it this way, as it keep the blocking semantics in ch-remote.
Fair question, tho!