Open
Conversation
rowanc1
force-pushed
the
feat/selection-plugin
branch
5 times, most recently
from
f5ef8a5 to
b0022a7
Compare
rowanc1
force-pushed
the
feat/selection-plugin
branch
from
db17a4a to
f3f3050
Compare
rowanc1
commented
Dec 21, 2021
Member
Author
rowanc1
left a comment
rowanc1
left a comment
There was a problem hiding this comment.
Taking a look through.
Comment on lines
+121
to
+125
| // TODO: This has to be based on the actual from/to | ||
| // NodeSelection.create(tr.doc, from); | ||
| // if (isNodeSelection(tr.selection)) { | ||
| // deco = Decoration.node(from, to, params, spec); | ||
| // } |
rowanc1
force-pushed
the
feat/selection-plugin
branch
from
2c55644 to
2396f4f
Compare
- fix selection.tsx update fn
rowanc1
force-pushed
the
feat/selection-plugin
branch
from
2396f4f to
c747270
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.