Return early from various search functions when the target is empty #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that if I went into a search/replace dialog Ox would freeze if I tried to find all instances of an empty string. This PR checks to see if the string given in both the search prompt, the replace prompt, and next_match/prev_match is empty. If so, return from the current function early.
Owner
|
Thank you for the contribution! Glad to see the search / replace is more robust now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that if I went into a search/replace dialog Ox would freeze if I tried to find all instances of an empty string.
This PR checks to see if the string given in both the search prompt, the replace prompt, and next_match/prev_match is empty. If so, return from the current function early.
This is my first time writing Rust 😅 and I've not written any tests..!