fix(cubesql): Handle array-typed columns in streaming SQL mode#11149
fix(cubesql): Handle array-typed columns in streaming SQL mode#11149MazterQyou wants to merge 1 commit into
Conversation
Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
|
Claude finished @MazterQyou's task in 1m 34s —— View job Claude PR ReviewReviewed the four-file change. Overall this is a focused, well-scoped fix that brings streaming-mode behavior in line with the non-streaming path (both now JSON-stringify non-scalar values) and is backed by a unit test in Verdict: LGTM — 0 high, 1 medium, 2 low. DetailsFindingsMedium — In Low —
Low —
Notes / Praise
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11149 +/- ##
==========================================
- Coverage 83.68% 79.20% -4.49%
==========================================
Files 257 474 +217
Lines 79384 96934 +17550
Branches 0 3563 +3563
==========================================
+ Hits 66434 76774 +10340
- Misses 12950 19642 +6692
- Partials 0 518 +518
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Check List
Description of Changes Made
This PR fixes handling array-typed columns in streaming mode. Related test is included.
This behavior is not documented and unsupported, so it should not be relied upon. The fix is being landed to bring streaming and non-streaming modes in line.