-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(tesseract): Support SQL API grouped sub-query joins #11138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
rust/cube/cubesqlplanner/cubesqlplanner/src/cube_bridge/subquery_join.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| use super::member_expression::{MemberExpressionDefinition, NativeMemberExpressionDefinition}; | ||
| use cubenativeutils::wrappers::serializer::{ | ||
| NativeDeserialize, NativeDeserializer, NativeSerialize, | ||
| }; | ||
| use cubenativeutils::wrappers::{NativeContextHolder, NativeObjectHandle}; | ||
| use cubenativeutils::CubeError; | ||
| use serde::{Deserialize, Serialize}; | ||
| use std::any::Any; | ||
| use std::rc::Rc; | ||
|
|
||
| /// A query-level join against an opaque sub-query, originating from the | ||
| /// SQL API (cubesql) `subqueryJoins`. `sql` is a complete, pre-rendered | ||
| /// SELECT; `on` is the join condition expressed as a member expression | ||
| /// (same shape as a parsed member expression: `cubeName` + `expression`). | ||
| #[derive(Serialize, Deserialize, Debug, Clone, nativebridge::NativeBridgeStatic)] | ||
| pub struct SubqueryJoinStatic { | ||
| pub sql: String, | ||
| #[serde(rename = "joinType")] | ||
| pub join_type: Option<String>, | ||
| pub alias: String, | ||
| } | ||
|
|
||
| #[nativebridge::native_bridge(SubqueryJoinStatic, with_static_meta)] | ||
| pub trait SubqueryJoin { | ||
| #[nbridge(field)] | ||
| fn on(&self) -> Result<Rc<dyn MemberExpressionDefinition>, CubeError>; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alias contract is trust-based.
aliasis consumed verbatim (no quoting) and the innersqlis emitted verbatim into the outer query. The PR description states the SQL API sends a pre-quoted alias and a controlled inner SELECT, which is fine for the cubesql producer, but the trait itself doesn't enforce or document the invariant. If any other caller ofbuildSqlAndParamsRustever populatessubqueryJoins(the JS BaseQuery now forwardsthis.options.subqueryJoinsfrom any caller), an unquoted/attacker-controlled alias would land in the FROM clause untouched.Consider tightening the doc-comment on this struct to state explicitly that:
aliasMUST be a fully-quoted identifier produced by the caller, andsqlis emitted verbatim and MUST come from a trusted, planner-side path.Optionally validate at compile time that
aliasstarts/ends with the quote character ("or the dialect-specific one). Worth at least a// SAFETY: …-style note here so the next reader doesn't reintroduce quoting at a different layer.