perf: fix 34 self-detected performance issues#4
Merged
Conversation
Run goperf on itself and fix all actionable issues: Slice preallocation (33 fixes): - Convert `var issues []Issue` to `make([]Issue, 0, N)` across 25+ Check() functions in all rule files - Preallocate in analyzer.go, fixer.go, main.go, types.go - Add capacity hints to helper function return slices String concatenation (1 fix): - Convert += to strings.Builder in benchmark.go generateBenchmarkCode() - Convert += to strings.Builder in benchmark.go joinPatterns() Map size hints: - Add size hint to byFile map in fixer.go Line splitting optimization: - Count newlines first to preallocate in types.go splitLines() Results: 147 issues → 113 issues (34 fixed) Remaining 113 are false positives (AST traversal loops) or low-priority suggestions (benchmark recommendations).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
var issues []Issuetomake([]Issue, 0, N)across 25+ functions+=tostrings.Builderin benchmark.goTest plan
go buildpassesgo test ./...passes./goperf ./...runs successfully with reduced issue count