-
Notifications
You must be signed in to change notification settings - Fork 0
404 Extend CL validation and imports #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
9f8b5b2
feat: add pLDDT to CL results table
jorisfu 24eb514
feat: add trivial PAE based validation
jorisfu 1ddc103
feat: trivial plDDT based validation
jorisfu 77498d5
fix: broken formula
jorisfu 0ab6fa0
fix monomer validation test
jorisfu 291bd7d
refactor: expose PAE as matrix for monomers
jorisfu 23d5b60
feat: PAE for multimers
jorisfu 1e0e30e
feat: pLDDT for multimers
jorisfu eabd547
feat: add PAE/plDDT consistently to multimer imports
jorisfu bcb054f
feat: proper PAE validation for multimers
jorisfu 58ac815
fix: adjust existing cl validation tests
jorisfu 634e712
fix: some alphafold import tests
jorisfu 2c66b35
tempfix: bridge monomer plots so method doesn't fail
jorisfu 7ecac2b
tempfix: bridge multimer plots so method doesn't fail
jorisfu 213e340
merge crosslinking
jorisfu f2518c1
chore: remove obsolete todos
jorisfu e13e2a3
chore: adjust some tests
jorisfu 0c645e5
chore: adjust some tests
jorisfu c1d55a1
feat: introduce parsing of _chem_comp table in cif-files
tE3m a935874
chore: fix existing tests
jorisfu d506787
chore: test for no pLDDT data within cif
jorisfu a034f65
chore: tests for PAE based CL validation
jorisfu 6ec24c0
chore: tests for pLDDT based CL validation
jorisfu ab538c7
feat: AF3 to AF2 PAE matrix translation
jorisfu e42066f
(AI) tests: PAE matrix reduction
jorisfu 036de6b
chore: remove unused imports
jorisfu e53e0cb
feat: only make bounds fields visible if manual bounds is selected mode
jorisfu f57bfc8
chore: black
jorisfu 9e27c43
fix tests
jorisfu 0cb9ec0
chore: black
jorisfu ed07ce9
fix more tests
jorisfu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| from enum import StrEnum | ||
|
|
||
|
|
||
| ATOM_SITE_PREFIX = "_atom_site." | ||
|
|
||
|
|
||
| class ATOM_SITE_COLUMNS(StrEnum): | ||
| """ | ||
| Enum containing all column names that should be present in | ||
| the _atom_site. table for mmCIF files from PDB or AFDB | ||
| """ | ||
|
|
||
| ID = f"{ATOM_SITE_PREFIX}id" | ||
| TYPE_SYMBOL = f"{ATOM_SITE_PREFIX}type_symbol" | ||
| LABEL_ATOM_ID = f"{ATOM_SITE_PREFIX}label_atom_id" | ||
| LABEL_ALT_ID = f"{ATOM_SITE_PREFIX}label_alt_id" | ||
| LABEL_COMP_ID = f"{ATOM_SITE_PREFIX}label_comp_id" | ||
| LABEL_ASYM_ID = f"{ATOM_SITE_PREFIX}label_asym_id" | ||
| LABEL_ENTITY_ID = f"{ATOM_SITE_PREFIX}label_entity_id" | ||
| LABEL_SEQ_ID = f"{ATOM_SITE_PREFIX}label_seq_id" | ||
| PDBX_PDB_INS_CODE = f"{ATOM_SITE_PREFIX}pdbx_PDB_ins_code" | ||
| CARTN_X = f"{ATOM_SITE_PREFIX}Cartn_x" | ||
| CARTN_Y = f"{ATOM_SITE_PREFIX}Cartn_y" | ||
| CARTN_Z = f"{ATOM_SITE_PREFIX}Cartn_z" | ||
| OCCUPANCY = f"{ATOM_SITE_PREFIX}occupancy" | ||
| B_ISO_OR_EQUIV = f"{ATOM_SITE_PREFIX}B_iso_or_equiv" | ||
| PDBX_FORMAL_CHARGE = f"{ATOM_SITE_PREFIX}pdbx_formal_charge" | ||
| AUTH_SEQ_ID = f"{ATOM_SITE_PREFIX}auth_seq_id" | ||
| AUTH_COMP_ID = f"{ATOM_SITE_PREFIX}auth_comp_id" | ||
| AUTH_ASYM_ID = f"{ATOM_SITE_PREFIX}auth_asym_id" | ||
| AUTH_ATOM_ID = f"{ATOM_SITE_PREFIX}auth_atom_id" | ||
| PDBX_PDB_MODEL_NUM = f"{ATOM_SITE_PREFIX}pdbx_PDB_model_num" | ||
|
|
||
|
|
||
| ATOM_SITE_LABEL_COMP_ID = ATOM_SITE_COLUMNS.LABEL_COMP_ID | ||
|
|
||
| ATOM_SITE_COLUMNS_NUMERIC = [ | ||
| ATOM_SITE_COLUMNS.ID, | ||
| ATOM_SITE_COLUMNS.LABEL_SEQ_ID, | ||
| ATOM_SITE_COLUMNS.CARTN_X, | ||
| ATOM_SITE_COLUMNS.CARTN_Y, | ||
| ATOM_SITE_COLUMNS.CARTN_Z, | ||
| ATOM_SITE_COLUMNS.OCCUPANCY, | ||
| ATOM_SITE_COLUMNS.B_ISO_OR_EQUIV, | ||
| ATOM_SITE_COLUMNS.AUTH_SEQ_ID, | ||
| ] | ||
|
|
||
| CHEM_COMP_PREFIX = "_chem_comp." | ||
|
|
||
|
|
||
| class CHEM_COMP_COLUMNS(StrEnum): | ||
| """ | ||
| Enum containing all column names that should be present in | ||
| the _chem_comp. table for mmCIF files from PDB or AFDB | ||
| """ | ||
|
|
||
| ID = f"{CHEM_COMP_PREFIX}id" | ||
| TYPE = f"{CHEM_COMP_PREFIX}type" | ||
| MON_NSTD_FLAG = f"{CHEM_COMP_PREFIX}mon_nstd_flag" | ||
| NAME = f"{CHEM_COMP_PREFIX}name" | ||
| PDBX_SYNONYMS = f"{CHEM_COMP_PREFIX}pdbx_synonyms" | ||
| FORMULA = f"{CHEM_COMP_PREFIX}formula" | ||
| FORMULA_WEIGHT = f"{CHEM_COMP_PREFIX}formula_weight" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me suspicious, since we just had a discussion where it was important that things stayed a dataframe. Not that I'm against changing this, it just feels like something that needs to be discussed at least briefly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can discuss this tomorrow surely, but using the PAE as it was previously is impossible (it's not really a DF, rather just a string packed into one row of a df) and casting it to a reasonable df would lead to worse performance in all aspects