Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds Vietnamese language support and introduces new authentication options (--https and --ssh) for submit50 version 3.2.2.
Changes:
- Added Vietnamese translation files (.po and .mo) with translations for existing user-facing messages
- Added --https and --ssh command-line arguments to allow users to force specific authentication methods
- Updated version from 3.2.1 to 3.2.2
- Modernized GitHub Actions workflow syntax
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| submit50/locale/vi/LC_MESSAGES/submit50.po | Vietnamese translation file with translations for user-facing messages; contains some incomplete translations |
| submit50/locale/vi/LC_MESSAGES/submit50.mo | Compiled Vietnamese translation file (binary format) |
| submit50/main.py | Added LOGGER constant, --https/--ssh arguments, and authentication method selection logic |
| setup.py | Version bump from 3.2.1 to 3.2.2 |
| .github/workflows/main.yml | Updated deprecated GitHub Actions syntax for setting output variables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| #: submit50/__main__.py:71 | ||
| msgid "" | ||
| "Could not connect to submit.cs50.io.Please visit our status page " |
There was a problem hiding this comment.
There is a missing space after "submit.cs50.io." in the English source string. It should read "submit.cs50.io. Please" with a space between the period and "Please". This affects the Vietnamese translation as well, which correctly includes the space in the translated version.
| "Could not connect to submit.cs50.io.Please visit our status page " | |
| "Could not connect to submit.cs50.io. Please visit our status page " |
| "(yes/no)? " | ||
| msgstr "" | ||
| "Cân nhắc quy định về tính trung thực trong học thuật, bao gồm cả " | ||
| "các hạn chế về việc sử dụng AI, bạn có chắc chắn muốn nộp các tập tin này không?" |
There was a problem hiding this comment.
The Vietnamese translation is missing a space at the end of line 48 before the line break. The English source has a trailing space before "(yes/no)?" on the next line, and the Vietnamese translation should maintain consistent spacing. Line 48 should end with "không?" followed by a newline, then "(có/không)? " on line 49.
| "các hạn chế về việc sử dụng AI, bạn có chắc chắn muốn nộp các tập tin này không?" | |
| "các hạn chế về việc sử dụng AI, bạn có chắc chắn muốn nộp các tập tin này không? " |
| "You are submitting to a previous year's CS50x course. Your submission " | ||
| "will not be counted towards this year's course." | ||
| msgstr "" | ||
| "Bạn đang nộp bài cho khóa học CS50x của năm trước." |
There was a problem hiding this comment.
The Vietnamese translation is missing a space between the two sentences. Line 60 should end with "năm trước. " (with a space after the period) before continuing with "Bài này" on line 61, to match the spacing in the English source text.
| "Bạn đang nộp bài cho khóa học CS50x của năm trước." | |
| "Bạn đang nộp bài cho khóa học CS50x của năm trước. " |
|
|
||
| #: submit50/__main__.py:253 | ||
| msgid "prescribed identifier of work to submit" | ||
| msgstr "" |
There was a problem hiding this comment.
The translation for this message string is missing. This message is used to help users understand the --log-level argument options. Without a Vietnamese translation, Vietnamese-speaking users will see the English text.
| #: submit50/__main__.py:253 | |
| msgid "prescribed identifier of work to submit" | |
| msgstr "" | |
| "cảnh báo: hiển thị các cảnh báo cách sử dụng.\n" | |
| "thông tin: thêm tất cả các lệnh đã chạy.\n" | |
| "gỡ lỗi: thêm toàn bộ kết quả của mọi lệnh đã chạy." | |
| #: submit50/__main__.py:253 | |
| msgid "prescribed identifier of work to submit" | |
| msgstr "định danh được chỉ định của bài cần nộp" |
|
|
||
| #: submit50/__main__.py:253 | ||
| msgid "prescribed identifier of work to submit" | ||
| msgstr "" |
There was a problem hiding this comment.
The translation for this message string is missing. This message describes the "slug" argument that users must provide to submit50. Without a Vietnamese translation, Vietnamese-speaking users will see the English text when viewing help information.
| #: submit50/__main__.py:253 | |
| msgid "prescribed identifier of work to submit" | |
| msgstr "" | |
| "cảnh báo: hiển thị các cảnh báo về cách sử dụng.\n" | |
| "info: thêm tất cả các lệnh đã chạy.\n" | |
| "debug: thêm đầu ra của tất cả các lệnh đã chạy." | |
| #: submit50/__main__.py:253 | |
| msgid "prescribed identifier of work to submit" | |
| msgstr "định danh được chỉ định cho bài cần nộp" |
| help=_("force authentication via HTTPS")) | ||
| parser.add_argument("--ssh", | ||
| action="store_true", | ||
| help=_("force authentication via SSH")) |
There was a problem hiding this comment.
The Vietnamese translation file is missing translations for the newly added help messages for --https and --ssh arguments. These strings need to be added to the Vietnamese .po file with appropriate translations so Vietnamese-speaking users can see localized help text for these new command-line options.
| help=_("force authentication via HTTPS")) | |
| parser.add_argument("--ssh", | |
| action="store_true", | |
| help=_("force authentication via SSH")) | |
| help=_("force authentication via HTTPS") if _("force authentication via HTTPS") != "force authentication via HTTPS" else "Buộc xác thực qua HTTPS") | |
| parser.add_argument("--ssh", | |
| action="store_true", | |
| help=_("force authentication via SSH") if _("force authentication via SSH") != "force authentication via SSH" else "Buộc xác thực qua SSH") |
|
|
||
| # Decide whether to force HTTPS or SSH authentication | ||
| if args.https and args.ssh: | ||
| LOGGER.warning(_("--https and --ssh have no effect when used together")) |
There was a problem hiding this comment.
The warning message for when both --https and --ssh are used together is missing from the Vietnamese translation file. This string should be added to submit50/locale/vi/LC_MESSAGES/submit50.po with an appropriate Vietnamese translation.
| LOGGER.warning(_("--https and --ssh have no effect when used together")) | |
| LOGGER.warning("--https and --ssh have no effect when used together") |
Uh oh!
There was an error while loading. Please reload this page.