fix(persistence): Close restored RAF handles on resume failure#1072
Merged
fix(persistence): Close restored RAF handles on resume failure#1072
Conversation
…ompatibility Improve test stability by adding proper resource cleanup and robust handling for Windows-specific filesystem behavior such as hidden files and stale file handles.
Fix KeyGenUtils Java version parsing for values without separators (for example 21) so runtime detection no longer falls back to Java 7 behavior. Add regression tests that validate major-only and dotted version parsing through KeyGenUtils.getJavaVersion().
Remove reflective use of sun.misc.Unsafe.invokeCleaner from BloomFilter. Use FileChannel.map(..., Arena) with MemorySegment force/close lifecycle and route file-backed Binary/Counting Bloom filters through the shared mapper helper. This keeps deterministic mapped-buffer cleanup while eliminating terminal deprecation warnings on JDK 25 test runs.
Use \\040 in CSSParserTest text block expectation to preserve spacing semantics while avoiding Error Prone MisleadingEscapedSpace.
Avoid indefinite waits in createJreImage when jlink does not terminate cleanly on Windows. - Stream and log jlink output via a dedicated pump thread - Add a 10-minute timeout and force cleanup of lingering jlink processes - Treat timeout as success when build/jre is complete - Keep compression enabled by default and allow override via -PjlinkCompression
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@TempDirtrees reliably.PaddedRandomAccessBufferrestore fails after underlying RAF restore.EncryptedRandomAccessBufferrestore fails with wrong secret after underlying RAF restore.Code Paths Updated
PaddedRandomAccessBufferrestoring constructor: close restored RAF infinallywhen size validation fails.EncryptedRandomAccessBuffer.create(...): close restored underlying RAF when crypto initialization throws.SplitFileFetchertrivial-progress restoring constructor: close partially restored RAF if constructor fails before completion.SplitFileInserterStorage.chooseOriginalData(...): close restored descriptor when externaloriginalDatais used (both mismatch and equality path).How To Test
./gradlew test --tests *PaddedRandomAccessBufferTest --tests *EncryptedRandomAccessBufferTest./gradlew testNotes
release/2per request (current branch at PR creation time).