feat: add support for string comments attachments#352
Merged
andrii-bodnar merged 1 commit intocrowdin:masterfrom Dec 9, 2025
Merged
Conversation
* Added an additional class to model the attachment; * Modified existing classes: StringComment and AddStringCommentRequest to contain a list of attachments; * Implemented the method to delete an attachment from a string comment; * Fixed a typo in the batch operations method (PATCH) to correctly redirect the user to documentation; * Modified JSON response files to mirror the attachment addition; * Tested the newly added method and added additional asserts in existing tests to ensure correct functionality after adding attachments;
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
============================================
+ Coverage 93.28% 93.29% +0.01%
- Complexity 903 904 +1
============================================
Files 202 202
Lines 3258 3261 +3
Branches 70 70
============================================
+ Hits 3039 3042 +3
Misses 183 183
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrii-bodnar
approved these changes
Dec 9, 2025
Member
andrii-bodnar
left a comment
andrii-bodnar
left a comment
There was a problem hiding this comment.
@andreichirila0712 thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for String/Asset Comments API. (closes: #347)
Changes:
Attachment.classto model the attachment;StringComment.classandAddStringCommentRequest.classclasses have been modified to contain a list of attachments;PATCH) to correctly redirect the user to the documentation;JSON) have been modified to take into account the newattachmentsfieldNotes: