feat: Add crossplane_managed_resource_* state metrics#308
Open
lkiii wants to merge 1 commit intocrossplane-contrib:masterfrom
Open
feat: Add crossplane_managed_resource_* state metrics#308lkiii wants to merge 1 commit intocrossplane-contrib:masterfrom
lkiii wants to merge 1 commit intocrossplane-contrib:masterfrom
Conversation
Add Prometheus state metrics for all managed resource types following the Crossplane contribution guide for provider observability. Metrics exposed: - crossplane_managed_resource_exists - crossplane_managed_resource_ready - crossplane_managed_resource_synced Each metric is labeled with GVK. Polls every 30 seconds. Signed-off-by: Lukas Ignatavičius <lukas@cashcoach.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add Prometheus state metrics for all managed resource types following the Crossplane observability guide.
Metrics exposed:
crossplane_managed_resource_exists- Count of existing managed resourcescrossplane_managed_resource_ready- Count of ready managed resourcescrossplane_managed_resource_synced- Count of synced managed resourcesEach metric is labeled with GVK (GroupVersionKind). Polls every 30 seconds.
Implementation:
pkg/controller/statemetrics.gowithSetupStateMetrics()functionMRStateRecorderfor all 22 managed resource types (PostgreSQL, MySQL, MSSQL - both cluster and namespaced)pkg/controller/statemetrics_test.goFixes #307
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
make reviewable):8080/metricscrossplane_managed_resource_existsincremented from 0 to 1 after the 30-second poll interval