Add Azure AD authentication support for mssql#166
Open
Mikel-Landa wants to merge 5 commits intocrossplane-contrib:masterfrom
Open
Add Azure AD authentication support for mssql#166Mikel-Landa wants to merge 5 commits intocrossplane-contrib:masterfrom
Mikel-Landa wants to merge 5 commits intocrossplane-contrib:masterfrom
Conversation
Member
|
Would you mind rebasing? |
Signed-off-by: Mikel Landa <mikel.landa@pepperservicing.es>
Signed-off-by: Mikel Landa <mikel.landa@pepperservicing.es>
Signed-off-by: Mikel Landa <mikel.landa@pepperservicing.es>
Author
|
@Duologic i've rebased it |
|
Any updates on this @Mikel-Landa @Duologic ? Would be nice to get this merged! |
bakito
added a commit
to bakito/provider-sql
that referenced
this pull request
Nov 12, 2024
Contributor
|
@Mikel-Landa This change looks promising and would cover a requirement, where I'd like to allow AD users temporary access to the database. |
Member
|
This might need another rebase, and don't forget to sign the commits. |
|
@Mikel-Landa Could you please provide some documentation e.g. in the form of an additional example for the ProviderConfig required for this to work, or specify how to configure this in the crossplane.yaml? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #165
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Created a local cluster and connected to an existing database. Tested a creation of a database, user and grant and then connected through ad to the database with the provisioned user