-
Notifications
You must be signed in to change notification settings - Fork 3
Backports Features to 3.x branch #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.x
Are you sure you want to change the base?
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 13058438 | Triggered | Generic High Entropy Secret | 51d04ce | tests/_data/magiclogin_authrecord.php | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
GitGuardian complaining about the test suite. No secret actually committed. |
|
HI guys any movement on this one? Ready for review regardless of gitguardian complaining (I didn't do anything to make it fail) |
|
Thanks for your patience here @MadMikeyB, a couple of points on this before I go ahead with the merge.
Could you please add a feat: to your commit on adding macros to settings page and remove bumping of composer and updates to the changelog? I noticed the test suite also didn't run but I can do this manually. Thanks |
Can't upgrade to Craft 5.x (other plugins not ready) yet but needed the Link Access Limit ( #31 ) functionality so have back-ported this plus the ability to allow setting overrides via config/magic-login.php ( #19 ) to the 3.x branch so that Craft 4.x users can take advantage of them.
Upon merge I suggest tagging this as version 3.1.2.