Skip to content

Conversation

@MadMikeyB
Copy link

@MadMikeyB MadMikeyB commented Aug 30, 2024

Can't upgrade to Craft 5.x (other plugins not ready) yet but needed the Link Access Limit ( #31 ) functionality so have back-ported this plus the ability to allow setting overrides via config/magic-login.php ( #19 ) to the 3.x branch so that Craft 4.x users can take advantage of them.

Upon merge I suggest tagging this as version 3.1.2.

@gitguardian
Copy link

gitguardian bot commented Aug 30, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13058438 Triggered Generic High Entropy Secret 51d04ce tests/_data/magiclogin_authrecord.php View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@MadMikeyB
Copy link
Author

GitGuardian complaining about the test suite. No secret actually committed.

@MadMikeyB
Copy link
Author

HI guys any movement on this one? Ready for review regardless of gitguardian complaining (I didn't do anything to make it fail)

@jaymeh
Copy link
Contributor

jaymeh commented Jan 29, 2025

Thanks for your patience here @MadMikeyB, a couple of points on this before I go ahead with the merge.

  • The changelog, tagging, and version bump should automatically be used when we trigger a release action, assuming that commits conform to the Conventional commit workflow.
  • In this instance, it likely won't create a 3.1.2 (fix release) because the backported commits are for new features.

Could you please add a feat: to your commit on adding macros to settings page and remove bumping of composer and updates to the changelog?

I noticed the test suite also didn't run but I can do this manually.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants