backup database to iCloud/iTunes#108
Open
chrisdrackett wants to merge 6 commits intocraftzdog:masterfrom
Open
Conversation
Ahmed32088
approved these changes
Sep 30, 2021
Owner
|
Did you check it works without any issue? |
Author
|
yeah, we're using it with our app now, I was able to backup to iCloud and then restore without losing any data |
|
Good job, it would be better if it is compatible with the old version, and do a little migration of the old version data |
Author
|
that's a really good point, but is currently beyond me. We handled the migration above in our JS code, but it would be nice if this library could handle it internally |
|
@chrisdrackett How did you handle the migration in JS? |
Ahmed32088
approved these changes
Oct 18, 2021
Author
|
any idea if/when this will be merged? Just starting a new project that also uses this and while I can patch there as well it would be nice not to have to... |
chichilatte
added a commit
to chichilatte/react-native-sqlite-2--allow-ios-backup
that referenced
this pull request
Aug 29, 2023
This is being applied to @craftzdog's master v3.6.2 (commit 64ec364). Here's the patch, a PR which has yet to be approved... craftzdog#108
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #105
I can't really think of a reason not to have this be the default. I actually can't even think of a reason for adding an option either, so we just updated the current behavior.