Skip to content

container is the one closest input #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandonkelly merged 3 commits into from
Mar 12, 2026
Merged

container is the one closest input #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
364695b
container is the one closest input
i-just Mar 12, 2026
a5cb841
Merge branch '5.x' into bugfix/523-matrix-blocks-cke-and-images
brandonkelly Mar 12, 2026
739f03f
Release note
brandonkelly Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased

- Fixed a bug where custom `toolbar` config settings were getting ignored. ([#522](https://github.com/craftcms/ckeditor/issues/522))
- Fixed a bug where files uploaded to Assets fields could also be added to nearby CKEditor fields. ([#523](https://github.com/craftcms/ckeditor/issues/523))

## 5.1.0 - 2026-03-05

Expand Down
2 changes: 1 addition & 1 deletion src/web/assets/ckeditor/dist/ckeditor5-craftcms.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/web/assets/ckeditor/src/image/imageinsert/imageinsertui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ export default class CraftImageInsertUI extends ImageInsertUI {
return;
}

this.$container = $(editor.sourceElement).parents('.input');
this.$container = $(editor.sourceElement).closest('.input');
this.progressBar = new Craft.ProgressBar(
$('<div class="progress-shade"></div>').appendTo(this.$container),
);
Expand Down
Loading