Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #589 +/- ##
============================================
+ Coverage 19.87% 20.02% +0.15%
- Complexity 1651 1672 +21
============================================
Files 310 311 +1
Lines 27302 27390 +88
Branches 4327 4340 +13
============================================
+ Hits 5425 5485 +60
- Misses 20972 20986 +14
- Partials 905 919 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c-schuler
requested changes
Nov 24, 2025
Contributor
c-schuler
left a comment
c-schuler
left a comment
There was a problem hiding this comment.
Looking good. I have a few suggestions. Also, will this operation work on an R5 bundle?
c-schuler
reviewed
Nov 24, 2025
tooling/src/main/java/org/opencds/cqf/tooling/operation/ConvertR5toR4.java
Outdated
Show resolved
Hide resolved
c-schuler
reviewed
Nov 24, 2025
tooling/src/main/java/org/opencds/cqf/tooling/operation/ConvertR5toR4.java
Outdated
Show resolved
Hide resolved
c-schuler
reviewed
Nov 24, 2025
tooling/src/main/java/org/opencds/cqf/tooling/operation/ConvertR5toR4.java
Outdated
Show resolved
Hide resolved
c-schuler
reviewed
Nov 24, 2025
tooling/src/main/java/org/opencds/cqf/tooling/operation/ConvertR5toR4.java
Outdated
Show resolved
Hide resolved
c-schuler
reviewed
Nov 24, 2025
tooling/src/main/java/org/opencds/cqf/tooling/operation/ConvertR5toR4.java
Outdated
Show resolved
Hide resolved
c-schuler
reviewed
Nov 24, 2025
tooling/src/main/java/org/opencds/cqf/tooling/operation/ConvertR5toR4.java
Outdated
Show resolved
Hide resolved
brynrhodes
approved these changes
Nov 25, 2025
- Keeps the runtime behavior of ConvertR5toR4 intact. - Significantly strengthens the test suite by asserting that: - All CLI conversions produce R4 Bundles. - Entry counts match the number of source resources for both single and multiple inputs. - Error paths for invalid encoding and invalid directories are enforced. - Cleans up test code style and ensures no test artifacts persist on disk after execution. - Removed operations/convert/ConvertR5toR4 class
c-schuler
approved these changes
Nov 25, 2025
Contributor
Author
raleigh-g-thompson
left a comment
raleigh-g-thompson
left a comment
There was a problem hiding this comment.
Looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves DBCG/aphl-vsm#565