Fixed NPE when packaging a measure with an unresolvable primary library reference#588
Open
brynrhodes wants to merge 2 commits intomasterfrom
Open
Fixed NPE when packaging a measure with an unresolvable primary library reference#588brynrhodes wants to merge 2 commits intomasterfrom
brynrhodes wants to merge 2 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #588 +/- ##
============================================
- Coverage 19.87% 19.86% -0.01%
- Complexity 1651 1652 +1
============================================
Files 310 310
Lines 27302 27307 +5
Branches 4327 4331 +4
============================================
- Hits 5425 5424 -1
- Misses 20972 20975 +3
- Partials 905 908 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
raleigh-g-thompson
requested changes
Sep 30, 2025
Contributor
raleigh-g-thompson
left a comment
There was a problem hiding this comment.
Maybe the code in the resolvePrimaryLibraryDependencies function works as expected, but not clear from the code the exact intent of this logic with regards to the local primaryLibrary and the instance's primaryLibrary value.
raleigh-g-thompson
approved these changes
Sep 30, 2025
Contributor
raleigh-g-thompson
left a comment
There was a problem hiding this comment.
Discussed implementation with Bryn and will accept current changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.