-
Notifications
You must be signed in to change notification settings - Fork 2
Upgrade to Spring Boot 4.0.1 with springdoc-openapi 3.0.1 #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Upgrade Spring Boot from 3.5.7 to 4.0.1 - Upgrade springdoc-openapi from 2.8.14 to 3.0.1 - Remove SecurityAutoConfiguration exclusion (class moved in Spring Boot 4) - Add spring-boot-starter-webmvc-test and restclient dependencies for tests - Update TestRestTemplate import to new package location - Add @AutoConfigureTestRestTemplate annotation to test classes - Fix Jackson 3 compatibility in RestResponsePage and RestResponseSlice - Update version references in README.md and application.properties - Enable springdoc API docs (disabled by default in 3.x) All 18 integration tests passing with Java 17 and 21.
Summary of ChangesHello @teetangh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on a significant upgrade of the application's core frameworks, moving from Spring Boot 3.5.7 to 4.0.1 and updating springdoc-openapi to version 3.0.1. This modernization effort involves resolving various breaking changes, updating build configurations, and ensuring continued functionality and test coverage with the new versions. The goal is to leverage the latest features and maintain compatibility with the evolving Spring ecosystem. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades Spring Boot to 4.0.1 and springdoc-openapi to 3.0.1, including necessary code changes to address breaking changes. The dependency updates, configuration changes, and test adjustments seem correct for the migration. However, I found a potential issue in the updated deserialization logic for RestResponseSlice that could lead to incorrect pagination behavior on the client-side. My review includes a specific suggestion to fix this.
Summary
Changes
SecurityAutoConfigurationexclusion (class moved in Spring Boot 4)JsonNodewithObject)TestRestTemplateimport to new package and added@AutoConfigureTestRestTemplateTest plan
Related PRs
This PR supersedes: