Skip to content

fix: existing account number increment on each callback#970

Open
freeelancer wants to merge 2 commits intocosmos:mainfrom
MANTRA-Chain:callback-check-acc
Open

fix: existing account number increment on each callback#970
freeelancer wants to merge 2 commits intocosmos:mainfrom
MANTRA-Chain:callback-check-acc

Conversation

@freeelancer
Copy link

Description

Currently each time IBCReceivePacketCallback it will trigger acc = k.authKeeper.NewAccountWithAddress(ctx, receiver) then k.authKeeper.SetAccount(ctx, acc). This causes the account number to change which is unexpected behavior.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@aljo242
Copy link
Contributor

aljo242 commented Feb 2, 2026

thank you for opening this @freeelancer - can you add some tests for this?

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.63%. Comparing base (4a67ba7) to head (e5993b1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
+ Coverage   65.57%   65.63%   +0.06%     
==========================================
  Files         319      319              
  Lines       22220    22221       +1     
==========================================
+ Hits        14571    14585      +14     
+ Misses       6480     6474       -6     
+ Partials     1169     1162       -7     
Files with missing lines Coverage Δ
x/ibc/callbacks/keeper/keeper.go 70.58% <100.00%> (+0.21%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vladjdk
Copy link
Member

vladjdk commented Feb 3, 2026

@freeelancer Can you please add an issue and associate this PR with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants