Skip to content

[master][CDRP-58] COBAR data processing issue#1

Open
polonevitch wants to merge 1 commit intocoretech:masterfrom
polonevitch:CDRP-58
Open

[master][CDRP-58] COBAR data processing issue#1
polonevitch wants to merge 1 commit intocoretech:masterfrom
polonevitch:CDRP-58

Conversation

@polonevitch
Copy link

As from the name of the function, native_pointer returns an actual address in memory by given offset through adding it to the mapped file starting position. I see from the code, it is covered by checks for null of the function return, but ignores a possibility of the null offset. This approach seems to be kind of useless, since the original function always returns not null result because of the not null mapped file address.
The PR does an additional check before summing values and gives a try for external check to prevent crash in case of a empty function parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant