feat: add a note about fine tuning chained rules #260
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @S0obi, thanks for this PR. I think the added content is good, but I'm not a native English speaker, so probably someone else from the team will review. There is an issue in link checker: it seems like the dokuwiki.org does not allow robots, so we need to handle this soon. |
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Following Slack discussion, fine tuning CRS chained rules like 920540 can be tricky to understand.
Using
ctl:ruleRemoveTargetByIdorSecRuleUpdateTargetByIdwill not have the expected effect as it will not be applied on all the rules of a chained rules, only the first one. Better to explicit this behavior to avoid misunderstanding and time wasted.