Merged
Conversation
sjp4
reviewed
Apr 7, 2026
| } | ||
| } | ||
| } else { | ||
| androidx.compose.foundation.layout.Spacer(modifier = Modifier.weight(1f)) |
| } | ||
|
|
||
| val expiration = app.muteExpiration | ||
| val now = kotlin.time.Clock.System.now() |
| HorizontalDivider(modifier = Modifier.padding(top = 8.dp)) | ||
| } | ||
| } | ||
| } else { |
Member
There was a problem hiding this comment.
Nesting here isn't very clear - might be better to have a separate if (iOS) { } block
asyba
force-pushed
the
notification_mute_status
branch
from
c847986 to
5542828
Compare
sjp4
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug was fixed where the mute toggle was not reflecting the correct status when the muteExpiration setting had an expired date and was subsequently reactivated.
A status was added to the notification app view that indicates whether the mute is always active, active on weekends/weekdays, or only active on specific hours/days.