Remove unnecessary test for diagnostic-only AnalyzeMCTDependencyPass #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AnalyzeMCTDependencyPass is a diagnostic-only pass that prints to stderr and doesn't affect compilation. The actual dependency analysis logic is duplicated in PlaceMCTOnCGRAPass and is already tested through placement tests. Removing this test reduces maintenance burden without losing test coverage. Co-authored-by: guosran <165251838+guosran@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update to address feedback on Spatial Task Placement
Remove unnecessary test for diagnostic-only AnalyzeMCTDependencyPass
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review feedback questioning the necessity of the
dependency-analysis.mlirtest file.Changes
test/multi-cgra/taskflow/dependency-analysis/dependency-analysis.mlirRationale
The
AnalyzeMCTDependencyPassis diagnostic-only (prints to stderr, no IR transformation). The actual dependency analysis logic lives inPlaceMCTOnCGRAPassand is already covered by placement tests (irregular-loop.mlir, etc.). Testing diagnostic output adds maintenance burden without value.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.