refactor: Enhance content mapping logic by ensuring safeField.id is s… #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et correctly and improving type matching in the ContentMapper component.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors content mapping logic in two files: it extracts type matching logic into a reusable variable in the ContentMapper UI component, and ensures the safeField.id is properly set in the API service.
Changes:
- Extracted type matching logic into
isTypeMatchvariable usingcheckConditions()function for better code reusability - Replaced direct field type comparisons with semantic matching via
checkConditions() - Added explicit assignment of
idtosafeFieldobject in the API service to ensure the field is properly set
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ui/src/components/ContentMapper/index.tsx | Refactored type matching logic by extracting it into an isTypeMatch variable and using it in both the value and isClearable props of the Select component |
| api/src/services/contentMapper.service.ts | Added explicit assignment of id to safeField to ensure the field is correctly set before being used in the returned object |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sayalijoshi27
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…et correctly and improving type matching in the ContentMapper component.