fix: Escape quotes and backslashes when quoting whitespace#204
Merged
k9withabone merged 1 commit intocontainers:mainfrom Apr 7, 2026
Merged
fix: Escape quotes and backslashes when quoting whitespace#204k9withabone merged 1 commit intocontainers:mainfrom
k9withabone merged 1 commit intocontainers:mainfrom
Conversation
pipex
force-pushed
the
quote-whitespace-escape-quotes
branch
from
031a7b4 to
687c773
Compare
k9withabone
approved these changes
Apr 1, 2026
Member
k9withabone
left a comment
k9withabone
left a comment
There was a problem hiding this comment.
Thanks for your contribution! This looks good! Seems like you just need to make sure your commit author email and your sign-off email match.
QuotedWhitespace adds a quote (`"`) around whitespaced strings, but it doesn't escape existing quotes inside the string leading to potentially wrong metadata being passed to entities created via quadlets. This escapes existing quotes and backslashes to ensure the generated output matches the intention of the user. Change-type: patch Fixes: containers#202 Signed-off-by: Felipe Lalanne <felipe@balena.io>
pipex
force-pushed
the
quote-whitespace-escape-quotes
branch
from
687c773 to
046db49
Compare
Contributor
Author
|
Updated the commit email @k9withabone, thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QuotedWhitespace adds a quote (
") around whitespaced strings, but it doesn't escape existing quotes inside the string leading to potentially wrong metadata being passed to entities created via quadlets.This escapes existing quotes and backslashes to ensure the generated output matches the intention of the user.
Change-type: patch
Fixes: #202